[sane-devel] Umax Astra 2100U corrected calibration, again
palessar at cgocable.ca
Sun Apr 16 15:54:24 UTC 2006
I've corrected the calibration for the 2100U. (again!)
Here is the source code.
On Tuesday 11 April 2006 22:31, Patrick Lessard wrote:
> Here is another one, I corrected something in the calibration of the 2100U.
> Please use this one instead.
> That should be the last for now...
> On Sunday 09 April 2006 17:42, Henning Meier-Geinitz wrote:
> > Hi,
> > On 2006-03-31 13:05, Patrick Lessard wrote:
> > > I did incorporate it into the backend.
> > Thanks. I'm currently looking at the code. I can't actually test it
> > because I don't have such a scanner so this is only theoretically.
> > It would be good if somebody could test your current code with a Astra
> > 1220U just to make sure that nothing is broken.
> > Comments:
> > in umax1220-common.c:
> > - Any reason to partly remove the DEBUG_BOUNDS code (and a + PAD
> > somewhere)?
> > - can all scanners cope with the bigger buffers:
> > - req = n = (len > 0xf000) ? 0xf000 : len;
> > + req = n = (len > 0xff00) ? 0xff00 : len;
> > - it looks like while you added move_2100, you also changed something
> > in move () itsself (sending longer buffers to the scanner with cwrite).
> > Does this also work with the 1220U?
> > in umax1220u.c:
> > - Why is the call to sanei_pv8630_init () removed? Without this I
> > think you can't use debugging for sanei_pv8630.
> > - Is there no problem removing this uncondinionally?
> > - res = UMAX_set_lamp_state (&scanner->scan, UMAX_LAMP_OFF);
> > I get some compilation warnings but these may have been already
> > present in the old code:
> > umax1220u.c:306: warning: dereferencing type-punned pointer will break
> > strict-aliasing rules umax1220u.c:348: warning: dereferencing type-punned
> > pointer will break strict-aliasing rules umax1220u.c:390: warning:
> > dereferencing type-punned pointer will break strict-aliasing rules
> > umax1220u.c:432: warning: dereferencing type-punned pointer will break
> > strict-aliasing rules umax1220u.c: In function
> > 'sane_umax1220u_control_option':
> > umax1220u.c:799: warning: format '%p' expects type 'void *', but argument
> > 7 has type 'SANE_Int *'
> > Generally it looks quite well. If the above comments are solved, I can
> > put your code in CVS. If you like you can also have CVS access then,
> > so you can mainatin the backend yourself.
> > Bye,
> > Henning
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 19581 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/sane-devel/attachments/20060416/d9018d52/umax1220u_backend_16042006-0001.bin
More information about the sane-devel