[sane-devel] adding stv680 backend to cvs

[Henning Meier-Geinitz]

Hi,

On 2006-04-26 21:44, gerard klaver wrote:
> I have stil some memory leakage errors (with valgrind xcam -B) when
> using my stv680 backend. But i think its ready for adding to SANE CVS so
> it can get a bigger audience and more testers.

I don't have such a device but I still had a quick look at the code:

- if you use GPLed code from other sources (add_text), I think you
  can't use the SANE GPL exception for your backend.

I get the following compilation warnings:
stv680.c: In function 'stv680_init_options':
stv680.c:1117: warning: cast discards qualifiers from pointer target type
stv680.c: In function 'stv680_fill_image':
stv680.c:1136: warning: format '%lx' expects type 'long unsigned int', but argument 3 has type 'size_t'
stv680.c:1144: warning: format '%lx' expects type 'long unsigned int', but argument 3 has type 'size_t'
stv680.c:1162: warning: format '%lx' expects type 'long unsigned int', but argument 3 has type 'size_t'
stv680.c:1162: warning: format '%lx' expects type 'long unsigned int', but argument 4 has type 'size_t'
stv680.c: In function 'stv680_bayer_unshuffle':
stv680.c:1295: warning: format '%lx' expects type 'long unsigned int', but argument 6 has type 'unsigned int'
stv680.c: In function 'sane_stv680_init':
stv680.c:1572: warning: implicit declaration of function 'sanei_config_open'
stv680.c:1572: warning: assignment makes pointer from integer without a cast
stv680.c:1582: warning: implicit declaration of function 'sanei_config_read'
stv680.c: In function 'sane_stv680_read':
stv680.c:2077: warning: format '%lx' expects type 'long unsigned int', but argument 3 has type 'size_t'
stv680.c:2077: warning: format '%lx' expects type 'long unsigned int', but argument 4 has type 'unsigned int'

Bye,
  Henning