[sane-devel] Status update for pixma backend

[Wittawat Yamwong]

Hi,

On Thursday 18 May 2006 22:07, Henning Meier-Geinitz wrote:
> Ok, let's have a quick look:
> +++ sane-backends-pixma/backend/pixma.c2006-05-14 00:03:53.000000000 +0200
> ...
> +#ifdef WITHOUT_SANEI
>
> Is this for a standalone mode? I guess that's not needed once the
> backend goes into SANE CVS?

Yes, it is for a standalone mode.  I'll remove it before the backend goes into 
the CVS.

> You seem to use fprintf and printf for debugging and information, but
> I haven't checked if this is called during normal usage. fprintf won't
> work over the net and printf won't work with programs using stdout for
> image data (e.g. scanimage).

fprintf() is only used if the backend is compiled as an external backend for 
testing (i.e. WITHOUT_SANEI is defined). For internal backend, all debug 
messages go through DBG(...) as defined in sanei_debug.h. To be sure, I'll 
remove all printf and fprintf from SANE CVS version.

> Otherwise it looks fine for me. I haven't looked at the source too
> much and I couldn't est compilation on anything but Linux/i386.
> In my opinion itÄs ok to put it into CVS.

Thank you for having a look at the code. Please wait a little bit. I'm fixing 
sane_get_devices() and sane_open(). They aren't compatible with the SANE 
standard yet. I think, everything will be ready for SANE CVS on this weekend.

Regards
-- 
Wittawat Yamwong
Hannover, Germany