[sane-devel] Xerox 2400 Onetouch

[Tony Sweeney]

On 19/04/11 05:31, stef wrote:
> Le Tuesday 19 April 2011 03:06:21 Tony Sweeney, vous avez écrit :
>> On 17/04/11 12:26, Tony Sweeney wrote:
>>> On 16/04/11 23:01, Daniel Elm wrote:
>>>> Tony and anyone else interested in this one,
>>>>
>>>> This particular scanner is a rebadged Visioneer OneTouch 7100.
>>>
>>> I win:
>>>
>>> sweeney at opcode:~/src/sane-backends$ git diff
>>> diff --git a/backend/genesys.conf.in b/backend/genesys.conf.in
>>> index fd2cd68..44d49bd 100644
>>> --- a/backend/genesys.conf.in
>>> +++ b/backend/genesys.conf.in
>>> @@ -105,3 +105,6 @@ usb 0x03f0 0x4605
>>>
>>> # Plustek OpticBook 3600
>>> usb 0x07b3 0x0900
>>> +
>>> +# Primax Electronics, Ltd Xerox 2400 Onetouch
>>> +usb 0x0461 0x038b
>>> diff --git a/backend/genesys_devices.c b/backend/genesys_devices.c
>>> index 8884409..bd3b261 100644
>>> --- a/backend/genesys_devices.c
>>> +++ b/backend/genesys_devices.c
>>> @@ -2693,6 +2693,7 @@ static Genesys_USB_Device_Entry
>>> genesys_usb_device_list[]
>>> {0x03f0, 0x0a01,&hp2400c_model},
>>> {0x03f0, 0x1405,&hp3670c_model},
>>> {0x0461, 0x0377,&medion_md5345_model},
>>> + {0x0461, 0x038b,&visioneer_7100_model}, /* Per Daniel Elm */
>>> {0x04a7, 0x0229,&visioneer_7100_model},
>>> {0x04a7, 0x0426,&visioneer_xp200_model},
>>> {0x0638, 0x0a10,&umax_astra_4500_model},
>>> sweeney at opcode:~/src/sane-backends$
>>>
>>> Grey and 8-bit colour are fine;
>>>
>>> http://www23.addr.com/~sweeney/win.png
>>> http://www23.addr.com/~sweeney/missing.png
>>>
>>> 16-bit, not so much:
>>>
>>> http://www23.addr.com/~sweeney/missing16.png
>>>
>>> I'm happy to dick with it some more given appropriate parameters.
>>
>> OK, I dicked with it some more: no changes in the software, but now the
>> scanner seems to work across gray&  colour at 8 + 16 bits; line art
>> scanning is not happening.  I'm more than happy to tidy this up and
>> submit a checkin with a nod from a maintainer.  Failing that, the best I
>> can do is generate a patch and try to make it searchable for fellow
>> cheapskates.
>>
>> Tony "Saving the world, one free scanner at a time" Sweeney.
>>
>>> Big thanks to Daniel,
>>>
>>> Tony.
>>>
>>>> -----Original Message-----
>>>> From: sane-devel-bounces+delm=bulletscan.com at lists.alioth.debian.org
>>>> [mailto:sane-devel-bounces+delm=bulletscan.com at lists.alioth.debian.org]
>>>> On
>>>>
>>>> Behalf Of Tony Sweeney
>>>> Sent: Saturday, April 16, 2011 5:34 AM
>>>> To: sane-devel at lists.alioth.debian.org
>>>> Subject: [sane-devel] Xerox 2400 Onetouch
>>>>
>>>> Hi,
>>>>
>>>> I got gifted one of these things:
>>>>
>>>> sweeney at opcode:~/src/sane-backends/doc$ lsusb
>>>> Bus 005 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
>>>> Bus 004 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
>>>> Bus 003 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
>>>> Bus 002 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
>>>> Bus 001 Device 003: ID 062a:0000 Creative Labs Optical mouse
>>>> Bus 001 Device 002: ID 0461:038b Primax Electronics, Ltd Xerox 2400
>>>> Onetouch
>>>> Bus 001 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
>>>> sweeney at opcode:~/src/sane-backends/doc$
>>>>
>>>> scanimage -v -v reports exactly as shown here:
>>>>
>>>> http://www.sane-project.org/unsupported/xerox-2400-onetouch.html
>>>>
>>>> I'd lke to have a stab at adding it to the Genesys backend. I'm a
>>>> reasonably competent C programmer, having ported Ingres to a variety of
>>>> platforms a few years ago. I have cloned the backend Git repository,
>>>> which configures and makes OK. What is the best way to proceed?
>>>>
>>>> Tony.
>
> 	Hello,
>
> 	do you mean adding the device description entry was enough to have it
> work for all but lineart ? If you made some more changes to the genesys
> backend, send patch to the list so it can be applied.

I changed two files, as shown by "git diff":

root at opcode:/home/sweeney/src/sane-backends/backend# git diff
diff --git a/backend/genesys.conf.in b/backend/genesys.conf.in
index fd2cd68..44d49bd 100644
--- a/backend/genesys.conf.in
+++ b/backend/genesys.conf.in
@@ -105,3 +105,6 @@ usb 0x03f0 0x4605

  # Plustek OpticBook 3600
  usb 0x07b3 0x0900
+
+# Primax Electronics, Ltd Xerox 2400 Onetouch
+usb 0x0461 0x038b
diff --git a/backend/genesys_devices.c b/backend/genesys_devices.c
index 8884409..bd3b261 100644
--- a/backend/genesys_devices.c
+++ b/backend/genesys_devices.c
@@ -2693,6 +2693,7 @@ static Genesys_USB_Device_Entry 
genesys_usb_device_list[]
    {0x03f0, 0x0a01, &hp2400c_model},
    {0x03f0, 0x1405, &hp3670c_model},
    {0x0461, 0x0377, &medion_md5345_model},
+  {0x0461, 0x038b, &visioneer_7100_model}, /* Per Daniel Elm */
    {0x04a7, 0x0229, &visioneer_7100_model},
    {0x04a7, 0x0426, &visioneer_xp200_model},
    {0x0638, 0x0a10, &umax_astra_4500_model},

The first simply adds the device entry to the end of genesys.conf[.in], 
and the second binds the USB device id exactly to the entry for the 
visioneer 7100 in the Genesys device list, per Daniel's suggestion. 
This is enough to make the device work as described.  I tested using 
xscanimage as root.  If it would be helpful to have the diff in an 
alternative format I would be happy to generate this.  If you would 
prefer that I add a xerox_onetouch_2400_model and test the individual 
GENESYS_FLAG_* flag capabilities properly I can do that too.

Tony.

>
> Regards,
> 	Stef
>
>