[sane-devel] New magicolor backend for inclusion in git

[m. allan noah]

I took a quick look at the code, and only see a few minor issues at
first glance.

1. MC_AutoDetectionTimeout is not configurable at runtime
2. the code only calls sanei_usb_init during sane_init. This prevents
long-running programs like button press daemons from finding
hotplugged scanners. This was discussed recently on the list.
3. Some of your Option Groups could get their names from saneopts.h
(SANE_NAME_GEOMETRY, TITLE, DESC, etc)

Other than those things, it looks fine to me.

allan

On Thu, Jan 6, 2011 at 4:39 PM, m. allan noah <kitno455 at gmail.com> wrote:
> Is the timeout controllable from the config file?
>
> allan
>
> On Thu, Jan 6, 2011 at 12:30 PM, Reinhold Kainhofer
> <reinhold at kainhofer.com> wrote:
>> As you know, I have been developing a magicolor backend for KONICA MINOLTA
>> magicolor 1690MF devices (possibly also for other devices, but I don't have
>> access to any other KONICA MINOLTA device that uses the same protocol -- The
>> bizhub devices use a different protocol).
>>
>> In my view, it is now in a state so that it can be included in sane-backends
>> (I'm using it regularly with xsane). The git patches can be found at:
>> http://www.fam.tuwien.ac.at/~reinhold/sane/magicolor_backend_patches/
>>
>> -) The first two (0001 and 0002) are for the sanei_usb functionality already
>> send yesterday,
>> -) 0003 is the actual backend,
>> -) 0004 fixes some compiler warnings in byteorder.h, and
>> -) 0005 includes only the changes from running autoreconf (i.e. no manual code
>> changes!)
>>
>>
>> The backend uses libsnmp (configure check added!) to optionally auto-detect a
>> LAN-connected magicolor device. I have set the timeout to a very low value (a
>> little more than 1 second!), so all systems without a magicolor scanning in
>> the network are not held up by the SNMP auto-detection of the magicolor
>> devices.
>> On the other hand, if the network is really slow, this might mean that we miss
>> an SNMP response that takes longer than 1 second!
>>
>> What do you think of this backend?
>>
>> Cheers,
>> Reinhold
>> --
>> ------------------------------------------------------------------
>> Reinhold Kainhofer, reinhold at kainhofer.com, http://reinhold.kainhofer.com/
>>  * Financial & Actuarial Math., Vienna Univ. of Technology, Austria
>>  * http://www.fam.tuwien.ac.at/, DVR: 0005886
>>  * LilyPond, Music typesetting, http://www.lilypond.org
>>
>> --
>> sane-devel mailing list: sane-devel at lists.alioth.debian.org
>> http://lists.alioth.debian.org/mailman/listinfo/sane-devel
>> Unsubscribe: Send mail with subject "unsubscribe your_password"
>>             to sane-devel-request at lists.alioth.debian.org
>>
>
>
>
> --
> "The truth is an offense, but not a sin"
>



-- 
"The truth is an offense, but not a sin"