[sane-devel] Other pixma_foo update for LSB

[Petrie, Glen]

Hi Johannes
 
I noticed that you submitted a bug fix request for the pixma_bjnp.c .
I do not know if you submitted the request in response to my bug request
for support of LSB builds or based on your own work; either way, I also
report two other "warning message" fix-it request in the the LSB bug
request.  Specically, 
 
 

pixma_mp810.c:519: warning: 'is_color' defined but not used

pixma_mp810.c:525: warning: 'is_color_48' defined but not used

pixma_mp810.c:531: warning: 'is_color_negative' defined but not used

pixma_mp810.c:537: warning: 'is_color_all' defined but not used

 

cause   :: Functions never used (called)

solution:: Remove functions using "#if 0"

 

 

pixma_sane_options.c:

In file included from pixma.c:1766:

pixma_sane_options.c: In function 'build_option_descriptors':

pixma_sane_options.c:73: warning: assignment discards qualifiers from
pointer target type

 

cause   :: Assignment from "const char*" to "char *" without casting.

solution:: Add casting to char*

 

 
 
While these are not critical fixes (not affecting code functionality) I
was hoping to eliminate all compile/link warning message for LSB builds.
Therefore, I would like to request and would greatly appreciate your
help resolving these two warning messages.
 
glen 
 
p.s. I not really sure who can/should submit bug fixes.   While I am
willing to submit bug fixes, I am not sure if the request should/can
come from me or should it come from the maintainer of the individual
modules 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/sane-devel/attachments/20121018/77292249/attachment.html>