[sane-devel] [PATCH] [RFC] add sanei_usb test program

Paul Menzel paulepanter at users.sourceforge.net
Thu Mar 14 15:23:17 UTC 2013


Dear Stef,


Am Freitag, den 08.03.2013, 21:55 +0100 schrieb Stef:

[…]

>      I really think this test program should be added, it doesn't add 
> extra dependency and helps testing a lot. For instance while adding a 
> test case for the problem Olaf spotted (not setting usb context to 
> null), it allowed me to find I also forgot to reset device_number to 0 
> in sane_exit().

I agree with your reasoning.

I think I spotted some small things. Could you please resend the patch
inlined, so I can answer inline with my email client? That would be
awesome.

You can do

    $ git format-patch -1

as you already did and copy that to the commit message body and make
sure to turn of automatic line wrapping in Thunderbird.


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/sane-devel/attachments/20130314/705487e8/attachment.pgp>


More information about the sane-devel mailing list