[sane-devel] git push issues

[Olaf Meeuwissen]

Hi Allan,

I just pushed most of the patches that Volker posted to the list[1] and
encountered some "trouble".

One of the patches triggered a mail to sane-commits that exceeded the
40kb limit.  The commit in question has a rather large diff and it looks
like the sane-backends repository's post-receive hook includes the whole
diff.  Wouldn't it be sufficient to just sent the commit message?

The second issue I ran into is that one of the patches triggered a

  make am--refresh

in the sane-backends-list-git working copy.  Both update-lists.sh and
update-search.sh in the post-receive hook may trigger this.  This went
like so:

  remote: cd .. && make  am--refresh
  remote: make[1]: Entering directory `/var/lib/gforge/chroot/home/groups/sane/sane-backends-lists-git'
  remote: /bin/bash ./config.status --recheck
  [...]
  remote: configure: creating ./config.status
  remote: chmod: changing permissions of `./config.status': Operation not permitted
  remote: configure: error: write failure creating ./config.status
  remote: make[1]: *** [config.status] Error 1
  remote: make[1]: Leaving directory `/var/lib/gforge/chroot/home/groups/sane/sane-backends-lists-git'
  remote: make: *** [../config.status] Error 2

The reason this fails is that kitno-guest owns config.status and the
make was run by olaf-guest (member of both sane and sane_scm groups).
User A cannot modify permissions of a file owner by user B, even if they
are both in the group that's assigned to the file.

This particular commit has no effect on the HTML pages or the backend
descriptions so it didn't break anything this time.  However, I think
the various scripts should run without ownership issues.  What do you
think?

I'm not sure about what would be the best way to deal with this and
welcome suggestions.

 [1] https://lists.alioth.debian.org/pipermail/sane-devel/2015-December/034167.html

Hope this helps,
-- 
Olaf Meeuwissen, LPIC-2            FSF Associate Member since 2004-01-27
Support Free Software               Support the Free Software Foundation
https://my.fsf.org/donate                        https://my.fsf.org/join
 GnuPG key: F84A2DD9/B3C0 2F47 EA19 64F4 9F13  F43E B8A4 A88A F84A 2DD9