[sane-devel] saned option handling changes (was Re: [PATCH v4 1/5] saned: parse standalone args in main())

Matteo Croce matteo at openwrt.org
Mon Oct 12 16:45:38 UTC 2015


Hi Olaf,

great, but I think that commit 45e66aee is wrong because it's
shadowing the global variable 'bind_addr'.
Also there is no need to initialize it to NULL because static
variables are always set to 0.

Cheers,
Matteo

2015-10-12 13:57 GMT+02:00 Olaf Meeuwissen <paddy-hack at member.fsf.org>:
> Hi Matteo,
>
> Matteo Croce writes:
>
> I was about to ping you about this ;-)
>
> I've pushed all your changes (plus a few nitpick changes) to Alioth's
> master.  The only thing that is still missing now is an updated manual
> page.  If you could take care of that, it'll be appreciated.
>
>> [...snip...]
>
> Hope this helps,
> --
> Olaf Meeuwissen, LPIC-2            FSF Associate Member since 2004-01-27
> Support Free Software               Support the Free Software Foundation
> https://my.fsf.org/donate                        https://my.fsf.org/join
>  GnuPG key: F84A2DD9/B3C0 2F47 EA19 64F4 9F13  F43E B8A4 A88A F84A 2DD9



-- 
Matteo Croce
OpenWrt Developer
  _______                     ________        __
 |       |.-----.-----.-----.|  |  |  |.----.|  |_
 |   -   ||  _  |  -__|     ||  |  |  ||   _||   _|
 |_______||   __|_____|__|__||________||__|  |____|
          |__| W I R E L E S S   F R E E D O M
 -----------------------------------------------------
 CHAOS CALMER
 -----------------------------------------------------
  * 1 1/2 oz Gin            Shake with a glassful
  * 1/4 oz Triple Sec       of broken ice and pour
  * 3/4 oz Lime Juice       unstrained into a goblet.
  * 1 1/2 oz Orange Juice
  * 1 tsp. Grenadine Syrup
 -----------------------------------------------------



More information about the sane-devel mailing list