[sane-devel] [pieusb] Fix unused-parameter compiler warnings

Olaf Meeuwissen paddy-hack at member.fsf.org
Sun Aug 28 06:03:01 UTC 2016


Hi Klaus,

The following functions in pieusb_scancmd.c trigger a pile of unused
parameter warnings:

  sanei_pieusb_cmd_get_exposure_time
  sanei_pieusb_cmd_get_halftone_pattern
  sanei_pieusb_cmd_get_highlight_shadow
  sanei_pieusb_cmd_set_ccd_mask
  sanei_pieusb_cmd_set_halftone_pattern

Upon closer inspection, I noticed that these functions are not called
anywhere in the backend and all but the get-halftone-pattern are stubs.

I'm trying to get rid of all compiler warnings and wondered how to fix
this.  I can completely remove the functions from the code or mark all
unused parameters with a __sane_unused__ on the assumption that they
will be unstubbed and used in the (near?) future.

What do you suggest?

Hope this helps,
-- 
Olaf Meeuwissen, LPIC-2            FSF Associate Member since 2004-01-27
 GnuPG key: F84A2DD9/B3C0 2F47 EA19 64F4 9F13  F43E B8A4 A88A F84A 2DD9
 Support Free Software                        https://my.fsf.org/donate
 Join the Free Software Foundation              https://my.fsf.org/join




More information about the sane-devel mailing list