[sane-devel] [RFC] mksotemp
kkaempf at suse.de
Mon May 9 13:32:17 UTC 2016
* Olaf Meeuwissen <paddy-hack at member.fsf.org> [May 09. 2016 15:10]:
> Alessandro Zummo writes:
> > On Mon, 02 May 2016 11:57:58 +0900
> > Olaf Meeuwissen <paddy-hack at member.fsf.org> wrote:
> >> That leaves zero flags to be passed, so the mkostemp() call reduces to
> >> mkstemp().
> >> I would simply call mkstemp() unconditionally. That way you also don't
> >> have to add it to AC_CHEC_FUNCS() in configure.in anymore.
> > I agree with you, but not being the original
> > author I didn't want to remove it all :)
> Simplicity is a virtue. There is no benefit in making the code more
> convoluted than necessary. Just call mkstemp() unconditionally. If
> you write a commit message that documents the rationale, I doubt the
> original author will complain.
No worries, just go ahead !
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
More information about the sane-devel