[sane-devel] [Janitorial] Zero(!) compiler warnings
paddy-hack at member.fsf.org
Wed Sep 21 13:12:27 UTC 2016
About a year ago, I set out trying to get rid of *all* compiler warnings
on a "well-defined" build platform. I'm happy to report that we've made
it! With the commit of ee550e5d, the debian-8-full build, is free
of compiler warnings!
Looking over the build log (love how clean those compile commands look,
BTW), next are four linker warnings about the use of `mktemp`, which, as
we all know, is racey and should be avoided. Like the plague, so I'd
like to see these get fixed.
# I have a patch for the avision backend already. By all means, tackle
# any of the canon, canon_dr and dc25 backends' use of mktemp.
There are still a number of description file entries looking for USB
product IDs and interfaces. I added several in 1a328e41 based on
what's in the Linux USB IDs list and will fix the typo I introduced
in a jiffy. I don't think it's realistic to get all of these fixed but
if you're willing (here's wishing the hpaio folks are listening in!) to
take a look, be my guest.
The debian-8-mini build is relatively clean, just a few minor things
due to the intentional lack of *any* libraries. The alpine-3.4.-musl
build hints at portability problems in the threading and parallel
The fedora-24-clang build? Let's leave that for another time. Much
of what you see there will pop up with gcc-6.x as well (which will be in
Debian 9, rumoured to release sometime early next year, IIRC).
Seeing that debian-8-full now builds without compiler warnings, I am
going to keep it that way by adding a CFLAGS="-Werror" to the `make`
invocation of the build. Remember: AWARE.
Oh and BTW, Debian released 8.6 last weekend so the Docker image used
for the debian-8-* builds will be updated some time soon as well.
Hope this helps,
Olaf Meeuwissen, LPIC-2 FSF Associate Member since 2004-01-27
GnuPG key: F84A2DD9/B3C0 2F47 EA19 64F4 9F13 F43E B8A4 A88A F84A 2DD9
Support Free Software https://my.fsf.org/donate
Join the Free Software Foundation https://my.fsf.org/join
More information about the sane-devel