[sane-devel] [janitorial] leading whitespace: spaces XOR tabs
doark at mail.com
Fri Aug 11 04:03:52 UTC 2017
On Wed, 12 Jul 2017 15:35:36 +0200
Gerhard Jäger <gerhard at gjaeger.de> wrote:
> > This whole exercise has made me look at the whole code base in a
> > little more detail and, quite frankly, the use of leading whitespace
> > is a total and utter mess. Some places are better of than others but
> > on the whole it's pretty pathetic.
> > > # Just make your editor visually distinguish spaces and tabs and
> > > you'll
> > # see. I used Emacs' whitespace-mode (in its default configuration)
> > and # it "lit up the place" in a variety of colours.
> > > So here's a few "rules" I'd like to apply in order to address
> > > this.
> > Each file
> > # Personally, I would much prefer to uses spaces everywhere the file
> > # format permits (with a minor execption for files used by make, see
> > # above) over the board.
> > # You may find the following blog post of interest ;-)
> > #
> > #
> > https://stackoverflow.blog/2017/06/15/developers-use-spaces-make-money-use-tabs/
> > > If anyone objects, I'm open to suggestions, including "Why bother?
> > > Just
> > use spaces!" ;-)
> > > If I hear nothing, the tools/style-check.sh script will be modified
> > > to
> > implement these rules and can then be use to check for any
> > "violations" and (recursively) fix them.
> Are you sure you want to rework the whole code base? Is it a good idea?
> Well maybe for unmaintained backends, but what about the others? In fact
> I have here some long pending patch (64 bit awareness) that most
> probably no longer apply.
Isn't this a moot point? Use "diff -w" or it's git alternative (I don't
know what it is).
More information about the sane-devel