Ubuntu 16.04 LTS cannot build recent Genesys backend

[Povilas Kanapickas]

Hi Rolf,

Thanks for making me aware of this. I'll look into the issue.

Olaf: would it make sense to have a configuration with an older compiler
toolchain to catch issues like this in the CI? There are Linux
distributions with long support cycles, so I think it's useful to have
some build testing for them. Concurrency is not currently a bottleneck
on the CI, so the builds won't become longer.

Regards,
Povilas

On 9/2/19 5:14 PM, Rolf Bensch wrote:
> Hi Povilas,
> 
> I just mentioned a new problem building genesys backend from Ubuntu
> 16.04 LTS.
> 
> This is the error message from Launchpad
> (https://launchpadlibrarian.net/439820893/buildlog_ubuntu-xenial-amd64.sane-backends_1.0.28+git20190901-xenial0_BUILDING.txt.gz):
> 
> /bin/bash ../libtool --silent  --tag=CXX   --mode=compile
> x86_64-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I../include/sane  -D_REENTRANT
> -DPATH_SANE_CONFIG_DIR=/etc/sane.d 	  -DPATH_SANE_DATA_DIR=/usr/share 	
> -DPATH_SANE_LOCK_DIR=/var/lock/sane 	  -DV_MAJOR=1 -DV_MINOR=0 -I. -I.
> -I../include -I../include -I/usr/include/libusb-1.0
> -DLIBDIR="\"/usr/lib/x86_64-linux-gnu/sane\""
> -DDEB_DLL_LIBDIR="\"/usr/lib/x86_64-linux-gnu/sane:/usr/lib/sane\""
> -DBACKEND_NAME=genesys  -Wall -Wextra -pedantic -std=gnu++11 -MT
> libgenesys_la-genesys_gl846.lo -MD -MP -MF
> .deps/libgenesys_la-genesys_gl846.Tpo -c -o
> libgenesys_la-genesys_gl846.lo `test -f 'genesys_gl846.cc' || echo
> './'`genesys_gl846.cc
> genesys_gl846.cc: In function ‘SensorExposure
> gl846_led_calibration(Genesys_Device*, const Genesys_Sensor&,
> Genesys_Register_Set&)’:
> genesys_gl846.cc:2005:37: error: could not convert ‘{exp[0], exp[1],
> exp[2]}’ from ‘<brace-enclosed initializer list>’ to ‘SensorExposure’
>      return { exp[0], exp[1], exp[2] };
>                                      ^
> 
> Many thanks in advance for fixing this.
> 
> Cheers,
> Rolf
>