[sane-devel] [janitorial] Code Freeze for 1.0.29 heads up

[Olaf Meeuwissen]

Hi Allan,

m. allan noah writes:

> I noticed that it is not possible to build sane-backends without
> libtiff installed, because hp3900 backend requires it, but configure
> does not check for it. This patch seems to fix:

Thanks for noticing and the patch but our CI has been running builds
without libtiff installed since the very beginning.  The latest such
build for release/1.0.29 is at

  https://gitlab.com/sane-project/backends/-/jobs/408050891

Checking the hp3900 source code shows that all TIFF functionality is
predicated on HAVE_TIFFIO_H.  The sane_cv_use_libtiff variable is
set based on the presence of tiffio.h *and* a TIFFFdOpen function in
libtiff, though.  Would you happen to compile on a system with the
header file present and no library with TIFFFdOpen by any chance?

# BTW, TIFF seems to be used only by debugging related functionality in
# the hp3900 backend.

Can you provide the config.log and config.status files for the build
where you run into this?  What distribution/version is this on?  What
are the TIFF related packages that are installed?

> diff --git a/acinclude.m4 b/acinclude.m4
> index 7c90c64f..f0d7d295 100644
> --- a/acinclude.m4
> +++ b/acinclude.m4
> @@ -598,6 +598,13 @@ for be in ${BACKENDS}; do
>      fi
>      ;;
>
> +    hp3900)
> +    if test "${sane_cv_use_libtiff}" != "yes"; then
> +      echo "*** $be backend requires TIFF library - $DISABLE_MSG"
> +      backend_supported="no"
> +    fi
> +    ;;
> +
>      dell1600n_net)
>      if test "${sane_cv_use_libjpeg}" != "yes" || test
> "${sane_cv_use_libtiff}" != "yes"; then
>        echo "*** $be backend requires JPEG and TIFF library - $DISABLE_MSG"

While I agree that applying this patch is a probably a good idea, there
is something inconsistent in the checking that I'd like to fix as well.

# The TIFF library check was added for the dell1600n_net backend.  It
# may be that the hp3900 backend's link flags picks up a library from
# one check and activates code based on another check (which happens to
# be *duplicated* by the library check).

> On Sun, Jan 26, 2020 at 7:02 AM Olaf Meeuwissen
> <paddy-hack at member.fsf.org> wrote:
>>
>> Hi all,
>>
>> Olaf Meeuwissen writes:
>>
>> > Hi all,
>> >
>> > Just so you all don't forget ;-)
>> >
>> > On 2020-01-26 around 12:00UTC, we'll be entering Code Freeze.  This only
>> > affects the release/1.0.29 branch.  The master branch is still open for
>> > code changes, new features, bug fixes and what not.
>>
>> We're past that point in time now and the release/1.0.29 branch is in
>> Code Freeze.  As per milestone[1] description, only "fixes for hardware
>> destroying bugs, compile failures, fixing completely unusable backends
>> and documentation fixes are allowed" now.
>>
>>  [1]: https://gitlab.com/sane-project/backends/-/milestones/3
>>
>> [...snip...]

Seeing that this is a compile failure, I'm inclined to include it in the
upcoming 1.0.29 on the condition that I understand what's going on with
your build.

Hope this helps,
--
Olaf Meeuwissen, LPIC-2            FSF Associate Member since 2004-01-27
 GnuPG key: F84A2DD9/B3C0 2F47 EA19 64F4 9F13  F43E B8A4 A88A F84A 2DD9
 Support Free Software                        https://my.fsf.org/donate
 Join the Free Software Foundation              https://my.fsf.org/join