[sane-devel] Updated patch for epson2 / epsonds

[Nakamura Iwao]

Dear All,

We have prepared the updated patch for epson2 / epsonds as the attached.
The main update from the previous release is as below : (Please refer the included "Release Note for Epson SANE driver update patch.pdf" also.)
	+ Fix the upside down issue for back side image when scanning with duplex ADF setting for some models
	+ Separate patch file to epsonds and epson2 for ease of review
	+ Prepare detail description about changes for ease of review (Epson SANE driver patch changes and descriptions.pdf)
Due to there is no known issues remaining from our testing perspective, we are thinking this is the final candidate release.
If you will find any issues, early feedback is helpful for us.

Best regards,
I.Nakamura
-----Original Message-----
From: Nakamura Iwao 
Sent: Wednesday, April 28, 2021 6:15 PM
To: Wolfram Sang <wsa at kernel.org>
Cc: Ralph Little <skelband at gmail.com>; sane-devel at alioth-lists.debian.net
Subject: RE: [EXTERNAL] Re: [EXTERNAL] Re: [sane-devel] Confrmation about license and distribution

Dear Wolfram-san and all,

During our internal review about "split into epson2 and epsonds", we found the issues of "epson2".
So, we will fix the issues of "epson2", split the patch into epson2/epsonds and release again for your review.
We are very sorry, however, please pending your review for "epson2" and wait for the next release.
(About review for "epsonds", it is still helpful for us.)

Best regards,
I.Nakamura
-----Original Message-----
From: Nakamura Iwao
Sent: Wednesday, April 28, 2021 9:59 AM
To: Wolfram Sang <wsa at kernel.org>
Cc: Ralph Little <skelband at gmail.com>; sane-devel at alioth-lists.debian.net
Subject: RE: [EXTERNAL] Re: [EXTERNAL] Re: [sane-devel] Confrmation about license and distribution

Dear Wolframe-san,

Thank you for your prompt feedback.
> Do you think it is possible to split it at least into an epson2 and epsonds part?
 =>	We will split patch into an epson2 and epsonds part on the next release.

> Can you also kindly double check which of the added debug output is still necessary after the development of the patch is complete now?
 =>	We will double check about the above until the next release.

> Looking forward to work together, enjoy the Golden Week!
 =>	Thank you. I will be out of office from Apr. 29th. to May 9th. Sorry for your inconvenience.

If anybody is possible to review and feedback for "epsonds" part, we appreciate it.

Best regards, 

I.Nakamura
------
Hello Nakamura-san,

> We have applied many pieces of changes for one improvement and we have 
> much difficulties to separate them to smaller patches which are free from dependencies among each patches.

Yes, it is very difficult afterwards if the patch has already been created. Do you think it is possible to split it at least into an epson2 and epsonds part?

> Then, instead of dividing to smaller patches, we would like to apply the followings for your easy to review.
> 	- Remove commented-out code

Can you also kindly double check which of the added debug output is still necessary after the development of the patch is complete now?

> 	- Add more comments for your review one by one for each changes

Yes, this will be helpful, too. Much appreciated!

> If you agree the above our approach, we will apply the above changes 
> and release again after waiting for other feedback and fixing the known issue (that is explained in the Release Note) around May 24th.

Thank you. I will have a look again at the patch and see if I have further comments.

Looking forward to work together, enjoy the Golden Week!

   Wolfram

-------------- next part --------------
A non-text attachment was scrubbed...
Name: SANE-patch-for-epsonds-epson2-20210518-5.zip
Type: application/x-zip-compressed
Size: 578775 bytes
Desc: SANE-patch-for-epsonds-epson2-20210518-5.zip
URL: <http://alioth-lists.debian.net/pipermail/sane-devel/attachments/20210521/f10d92db/attachment-0001.bin>