[sane-devel] Updated patch for epson2 / epsonds

Nakamura Iwao Nakamura.Iwao at exc.epson.co.jp
Fri May 28 07:54:50 BST 2021


Dear Wolfram-san,

Thank you for your positive feedback.
About your question, we have implemented Zeroconf support to implement auto scanner discovery.
However, this is only needed for "epsonds", because "epson2" already has this feature by the other logic.
i.e. We have accidentally implemented this feature to "epson2" then simply just remove it.
(In the Release Note, you can find "Undo the improper modification to epson2" and this means remove Zeroconf implementation from "epson2".) 

Dear All,
Could you please review "epsonds" patch as earlier as possible, if anybody can do that?
Or if there is any recommendation or proposal to move forward it, please advise.
(ex. Is it better to make marge request via GitLab?)

We appreciate your support.

Best regards,
I.Nakamura
-----Original Message-----
Hello Nakamura-san,

> The main update from the previous release is as below : (Please refer the included "Release Note for Epson SANE driver update patch.pdf" also.)
> 	+ Fix the upside down issue for back side image when scanning with duplex ADF setting for some models
> 	+ Separate patch file to epsonds and epson2 for ease of review

This is already helpful.

> 	+ Prepare detail description about changes for ease of review (Epson 
> SANE driver patch changes and descriptions.pdf)

Wow, this is really helpful! I don't maintain the epsonds driver, but the comments you added will be of great help for the person looking at the code. Thank you very much for doing it!

> Due to there is no known issues remaining from our testing 
> perspective, we are thinking this is the final candidate release.

I have one question: The first version you sent also had Zeroconf support for the epson2 driver. This is not present here, only in the epsonds driver. Any reason it was removed?

The epson2 changes in this package are fairly trivial. I will have a closer look this weekend and most likely apply them right away.

Thank you for your work!

Kind regards,

   Wolfram




More information about the sane-devel mailing list