[sane-devel] mystery why sane-backend umax_pp always builds

[Ralph Little]

Hi,

On 2022-07-24 10:44, r. a. schmied wrote:
> On 07/22/22 09:30, Ralph Little wrote:
>> Hi,
>>
>> On 2022-07-22 08:56, Ralph Little wrote:
>>> Hi,
>>>
>>> On 2022-07-21 12:19, r. a. schmied wrote:
>>>> saners
>>>>
>>>> the missing '/' on line ending umax
>>>> (see rcsdiff -uBitwb configure.ac below)
>>>> might be why the umax_pp always
>>>> builds even with an envvar like
>>>> export BACKENDS='genesys net test'
>>>> passed to configure.
>>>>
>>>> yet to determine 1) why the backends
>>>> umax1220u v4l xerox_mfp p5
>>>> *do not get* built along with umax_pp and
>>>> 2) if the added '/' will have any actual effect.
>>>>
>>>> i doubt this will have desired effect, as the
>>>> Makefile(s) do have 'BACKENDS =  genesys net test'
>>>> and do not have umax_pp (or any other backend)
>>>> in any obviously related envvar/macro.
>>>>
>>>> same missing '/' and build situation exists for
>>>> sane-backends-1.0.32.86-911be
>>>> and
>>>> sane-backends-1.0.28
>>>>
>>>>
>>>> ras
>>>>
>>>> --- configure.ac    2022/07/21 17:45:34    1.1
>>>> +++ configure.ac    2022/07/21 17:45:51
>>>> @@ -671,7 +671,7 @@
>>>>          mustek_usb mustek_usb2 nec net niash pie pieusb pint \
>>>>          pixma plustek plustek_pp qcam ricoh ricoh2 rts8891 s9036 \
>>>>          sceptre sharp sm3600 sm3840 snapscan sp15c st400 \
>>>> -        stv680 tamarack teco1 teco2 teco3 test u12 umax
>>>> +        stv680 tamarack teco1 teco2 teco3 test u12 umax \
>>>>          umax_pp umax1220u v4l xerox_mfp p5"
>>>>
>>>>  # If user specifies backends manually then cause configure
>>>>
>>> OK, I looked into this a little bit.
>>>
>>> The issue is actually caused by the tools/ directory which builds a
>>> tool called umax_pp.
>>> This tool has a dependency on umax_pp_low which is why, despite the
>>> umax_pp backend being disabled, the umax_pp_low.c source is built.
>>> There doesn't appear to be a configured way to disable this being
>>> built so I will add something.
>>>
>>> Thanks for raising this issue.
>>>
>>> Cheers,
>>> Ralph
>>>
>> OK, more detail on this.
>>
>> The umax_pp tool in the tools directory is always built. However, if you
>> disable the umax_pp backend then it merely sets the umax_pp tool to not
>> install, yet it is still built.
>> I think it is fair to say that if you are disabling the umax_pp backend,
>> then you are likely not interested in the umax_pp tool so I have removed
>> the build/noinstall option.
>>
>> I have added a check-in that if you disable the umax_pp backend, the
>> tool is not built.
>>
>> Cheers,
>> Ralph
>>
>>
>
> aloha ralph and interested saners
>
> ralph your analysis from a black-box view looks correct.
> i've got sane-backends-1.0.27 installed and tools/umax_pp
> was not installed, but tools/umax_pp was compiled and linked.
>
> for both sane-backends-1.0.28 and sane-backends-1.0.32.86-911be
> tools/umax_pp was compiled and linked.  neither of these versions
> have been installed yet [well 1.0.32.86-911be does not work, and
> while 1.0.28 is better than 1.0.27 i keep messing with 1.0.28
> to see if i can get it 'better' or at least more to my liking.
>
> [ backend issues with lide 200 and the contrast and brightness settings
>   and frontend issues [scanimage] with options and arguments that
>   as a gray-beard command liner (and horrible typist) drive me crazy ]
>
> is the 'check-in' patch simple enough for an email transmittal?
> not critical, now that i understand the reason i can stop wondering
> why.
>
> ras
>

Sure, the change is very simple.

Look at the top of tools/Makefile.am and remove the following lines 14 
and 15:

else
noinst_PROGRAMS += umax_pp

Then configure and build again. I don't think that you would need to do 
autogen.sh again although it wouldn't hurt.

Cheers,
Ralph
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/sane-devel/attachments/20220724/9c3172c3/attachment-0001.htm>