<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#ffffff">
On 05/11/2009 12:12 AM, stef wrote:
<blockquote cite="mid:200905110712.57863.stef.dev@free.fr" type="cite">
<pre wrap="">Le Sunday 10 May 2009 04:51:56 <a class="moz-txt-link-abbreviated" href="mailto:chris@cnpbagwell.com">chris@cnpbagwell.com</a>, vous avez écrit :
</pre>
<blockquote type="cite">
<pre wrap="">The following commit has been merged in the master branch:
commit 3ba551592c3ad71f82f6b0b2e19c248cc8fe40c1
Author: <a class="moz-txt-link-abbreviated" href="mailto:chris@cnpbagwell.com">chris@cnpbagwell.com</a> <a class="moz-txt-link-rfc2396E" href="mailto:chris@cnpbagwell.com"><chris@cnpbagwell.com></a>
Date: Sat May 9 21:50:35 2009 -0500
Adding changelog for recent commit.
diff --git a/ChangeLog b/ChangeLog
index 0146403..e68983f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,6 @@
+2009-05-09 Chris Bagwell <cbagwell-guest at users.alioth.debian.org>
+ * */*.c: standardize including local sane include files.
+
2009-05-09 Nicolas Martin <nicols-guest at users.alioth.debian.org>
* backend/pixma_mp150.c, doc/descriptions/pixma.desc:
Fixed Pixma MP600 and MP600R for 2400 dpi scan, updated their
descriptions.
</pre>
</blockquote>
<pre wrap=""><!---->
Hello,
I have a couple of problems with commits regarding this entry.
First I don't find */*.c a useful changelog entry.
</pre>
</blockquote>
Sorry, bit of laziness but hoped it read correctly in that every *.c
file was touched in some way (at least by a sed script) and so this
commit should be treated suspect as such.<br>
<blockquote cite="mid:200905110712.57863.stef.dev@free.fr" type="cite">
<pre wrap=""> Second, I really think that active maintainers should be asked on the sane-
devel list before changing the code they responsible for. Then go for the
change if there is no answer in a decent amount of time.
</pre>
</blockquote>
This is going to come up from time to time... There are housekeeping
items I'd like to do such as these header bugfixes/cleanups (depending
on file if its a bug), standardizing on stdint.h types when portability
becomes an issue, etc.<br>
<br>
I'd think this particular patch would bore people to death reading it
but if authors prefer a heads up then not much issue from my side to
publish diff to mailing list first.<br>
<br>
<br>
<blockquote cite="mid:200905110712.57863.stef.dev@free.fr" type="cite">
<pre wrap="">
BTW is there any way to include the diffstat in commit messages ? I think
this would make them more readable.
</pre>
</blockquote>
I second that... I preferred the diffstat over actual diffs if thats
possible.<br>
<br>
Another would be to have the subject line contain diff summary instead
of the current subject line its using.<br>
<br>
Chris<br>
<blockquote cite="mid:200905110712.57863.stef.dev@free.fr" type="cite">
<pre wrap="">
Regards,
Stef
--
sane-devel mailing list: <a class="moz-txt-link-abbreviated" href="mailto:sane-devel@lists.alioth.debian.org">sane-devel@lists.alioth.debian.org</a>
<a class="moz-txt-link-freetext" href="http://lists.alioth.debian.org/mailman/listinfo/sane-devel">http://lists.alioth.debian.org/mailman/listinfo/sane-devel</a>
Unsubscribe: Send mail with subject "unsubscribe your_password"
to <a class="moz-txt-link-abbreviated" href="mailto:sane-devel-request@lists.alioth.debian.org">sane-devel-request@lists.alioth.debian.org</a>
</pre>
</blockquote>
<br>
</body>
</html>