[Soc-coordination] [Patch] Limit image size to 4GB on FAT filesystems for lil'debi application

[Hans-Christoph Steiner]

Hey Kumar,

Overall the patch looks good.  One comment about the code style.  It is
important to match the code style of a project that you are contributing to.
Things like using camelCase for names in Java code (i.e. fileSystemName
instead of filesystem_name, or fileSystemType instead of filesystemtype).
This makes the code more readible.

Another is to use an automatic code formatter that matches the project.  This
is important because any little change to the code can make merging and
rebasing a lot more difficult.  When everyone uses the exact same code format,
and it is done automatically, that minimizes trivial changes in commits, like
whitespace, etc.

So LilDebi uses the Android mode of the Eclipse formatter, but the default
Eclipse formatter is fine.

You can see the difference in lines like this:

	public static String fileSystemType() {

versus what you currently have:

	public static String filesystemtype(){

There are many other code formatters, so you can use any as long as it
generates the same format.  astyle is another popular one that is a terminal
program.

.hc

On 04/07/2014 03:25 PM, Kumar Sukhani wrote:
> Hi all,
> 
>     I am Kumar Sukhani, applying for the project 'Integrate Debian with
> Android' for GSOC and link
> of my proposal is
> here<https://wiki.debian.org/SummerOfCode2014/StudentApplications/Kumar%20Sukhani>
> [1]. In addition to that I have also submitted one
> patch<https://github.com/guardianproject/lildebi/pull/92>[2]
> adding feature to
> 'Limit image size to 4GB on FAT filesystems' for the
> issue#80<https://github.com/guardianproject/lildebi/issues/80>
> [3]. Please reviews my proposal and
> patch and suggest changes if any are required.
> 
> Currently I am going through the code of lil'debi and comparing the same
> with similar project like
> 1) linuxonandroid -
> http://sourceforge.net/p/linuxonandroid/codegit/ci/master/tree/
> 2) cuntubuntu - https://github.com/pelya/cuntubuntu
> 
> Awaiting you reply.  Thanks in advance.
> 
> [1]
> https://wiki.debian.org/SummerOfCode2014/StudentApplications/Kumar%20Sukhani
> [2] https://github.com/guardianproject/lildebi/pull/92
> [3] https://github.com/guardianproject/lildebi/issues/80
> 
> --
> Kumar Sukhani
> 

-- 
PGP fingerprint: 5E61 C878 0F86 295C E17D  8677 9F0F E587 374B BE81