[Surfraw-devel] surfraw-2.2.2: A bashism and a conflicting name

[Ian Beckwith]

On Sun, Aug 24, 2008 at 12:18:59PM +0200, Thomas Klausner wrote:
> Hi!
> 
> There's a bashism in elvi/google:
> -if test -n "$SURFRAW_lang" -a "$SURFRAW_google_country" == "us"; then
> +if test -n "$SURFRAW_lang" -a "$SURFRAW_google_country" = "us"; then

Already fixed in CVS, thanks.

> Also, please don't install "sr": if someone wants it, he or she can
> very easily define an alias for it, and the name conflicts with the
> "sr" executable from the language of the same name
> (http://www.cs.arizona.edu/sr/). I can send patches for this if you
> want.

I'm reluctant to get rid of it completely, as a lot of people are
probably used to typing it, but I've just committed code that lets you
do:

./configure --disable-sr

which will disable installing the sr alias.

Ian.

-- 
Ian Beckwith - ianb at erislabs.net - http://erislabs.net/ianb/
GPG fingerprint: AF6C C0F1 1E74 424B BCD5  4814 40EC C154 A8BA C1EA
Listening to: 65 Days of Static - Don't Go Down to Sorrow