[Surfraw-devel] Surfraw 2.2.7: new beta

[Ian Beckwith]

Hi,

On Thu, Apr 22, 2010 at 03:41:14AM +0200, fittabile at lifegate.it wrote:
> Attached patch for
> - debwiki: wiki on women.debian.org ceased to exist

Thanks, committed.

> - bookmarks: was passing wrong arg?

Are you sure about this? Maybe I'm missing something, but in your patch:

> --- surfraw-2.2.7/surfraw.IN	2010-03-02 04:23:23.000000000 +0100
> +++ surfraw-2.2.7.new/surfraw.IN	2010-04-22 03:11:02.000000000 +0200
> @@ -534,7 +534,7 @@
>  		then
>   			sh -c "$elvidir/$elvi $opts $searchterms"
>  		else
> -			bookmark=`bookmark_lookup $elvi`
> +			bookmark=`bookmark_lookup $arg`
>  			if [ -n "$bookmark" ]
>  			then
>  				w3_parse_args $unquoted_opts

the 'for arg in "$@"' loop has finished, so $arg happens to contain the
last command line argument, whereas $elvi contains the first non-option
argument, which is what we want. I admit the variable names could be
clearer.

thanks.

Ian.

-- 
Ian Beckwith - ianb at erislabs.net - http://erislabs.net/ianb/
GPG fingerprint: AF6C C0F1 1E74 424B BCD5  4814 40EC C154 A8BA C1EA
Listening to: Grails - Burning Off Impurities - Origin-ing
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 237 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/surfraw-devel/attachments/20100422/ed50a5eb/attachment.pgp>