[Surfraw-devel] [PATCH] Fixed occurence of empty menu item

Sumant Oemrawsingh soemraws at xs4all.nl
Thu May 6 21:02:12 UTC 2010


On Thu, May 06, 2010 at 09:21:54PM +0100, Ian Beckwith wrote:
> On Sat, May 01, 2010 at 02:17:38AM +0200, Sumant Oemrawsingh wrote:
> > A space and tab in the bookfinder elvi description messed up the menu
> > presented by uzbl_load_url_from_surfraw. Cut used the tab character as a
> > delimiter, so the space became an entry on its own. Using awk instead of cut
> > fixes this problem.
> 
> Yes, that whitespace is tweaked so sr -elvi lines up, and has no other
> guarantees.
> 
> I've sneaked your fix into the just-released 2.2.7, although I've just
> realised it should probably use @AWK@ so ./configure can pick the awk
> implementation to use. Oh well, it's only a tiny issue, I'll fix that
> later.

The whitespaces line up just fine. However, I noticed that while other elvi do
this by using tab characters, bookfinder does this with a space and tab
character. Instead of messing around with the elvi, I decided to make the
script more robust.

Ah, yes, I forgot about @AWK@, sorry. I also noticed that the grep before the
awk call can be removed by just changing the awk pattern. I'll submit another
fix one of these days...

Thanks,
Sumant


-- 
Sumant Oemrawsingh



More information about the Surfraw-devel mailing list