[Surfraw-devel] Bug#928252: surfraw: extra /bin/sh hanging in memory

[Dmitry Bogatov]

Package: surfraw
Version: 2.3.0-0.2
Severity: wishlist

Dear Maintainer,

when I invoke "BROWSER=w3m surfraw duckduckgo my-search-term" I get
following pstree:

  |-bash---surfraw---sh---duckduckgo---w3m---3*[{w3m}]

Notice, there is multiple /bin/sh processes hanging in memory while I am
browsing. At least first of them is caused by following code in
/usr/bin/surfraw (lines 671-678):

	localelvidir=$(get_local_elvi_dir)
	if [ -x "$localelvidir/$elvi" ]
	then
		sh -c "$localelvidir/$elvi $opts $searchterms"
	elif [ -x "$elvidir/$elvi" ]
	then
		sh -c "$elvidir/$elvi $opts $searchterms"
	else

There is no more code after those 'sh -c', so adding 'exec' would
improve code.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/surfraw-devel/attachments/20190430/2afedb7d/attachment.sig>