[Syslog-ng-maintainers] Bug#885248: syslog-ng: FTBFS on hurd-i386: typos in get_path_max

Svante Signell svante.signell at gmail.com
Wed Dec 27 22:24:24 GMT 2017


tags 885248 patch
thanks

On Mon, 2017-12-25 at 22:43 -0500, Aaron M. Ucko wrote:
> Source: syslog-ng
> Version: 3.13.2-1
> Severity: important
> Tags: upstream
> Justification: fails to build from source (but built successfully in
> the past)
> 
> Builds of syslog-ng for hurd-i386 (admittedly not a release
> architecture) have been failing lately:
> 
>              pathmax++;
>              ^~~~~~~

> It's great that directory-monitor.c already attempts to accommodate
> systems like the Hurd with no fixed PATH_MAX, but there are a couple
> of typos in the relevant code.  Please try removing the unbalanced
> (and unneeded) { on line 65 and fixing the spelling of path_max on
> line 87.

Attached is a patch fixing the PATH_MAX issue. In fact the whole
function get_path_max() is obsolete with the patch. For now it is
commented out.

Regarding the GNU/Hurd build one (1/70) test fails: 

FAIL: lib/logproto/tests/test_logproto
======================================

[2017-12-27T21:07:38.640000] Plugin module not found in 'module-path';
module-path='(null)', module='syslogformat'

Until the cause for module-path being null is found the build will not
succeed. However, the PATH_MAX issue is solved.
(A suspicion is that that a python module creates that empty module-
path. To be verified and solved.)

Thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: modules-affile_directory-monitor.c.patch
Type: text/x-patch
Size: 1149 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/syslog-ng-maintainers/attachments/20171227/35f12685/attachment-0001.bin>


More information about the Syslog-ng-maintainers mailing list