[Tts-project] Bug#871440: stretch-pu: package speech-dispatcher/0.8.6-4+deb9u1

[Samuel Thibault]

Package: release.debian.org
Severity: normal
Tags: stretch
User: release.debian.org at packages.debian.org
Usertags: pu

Hello,

In #860898 it was reported that the configuration tool for
speech-dispatcher, spd-conf, is completely broken in Stretch.  Since
it took a long time for the report to come, we considered it a not bad
enough bug to propose a change before the release.

It however seems that now that Stretch is released, users are really
having problems with not having a working spd-conf (see thread starting
at https://lists.debian.org/debian-accessibility/2017/08/msg00002.html),
to the point that they are considering reverting to Jessie (see "How
long id Jessie supported?" at
https://lists.debian.org/debian-accessibility/2017/08/msg00010.html)

The fix for spd-conf is really simple, see the attached patch (already
applied upstream) which I propose to upload to Stretch.

Samuel

-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 'testing-debug'), (500, 'stable-debug'), (500, 'buildd-unstable'), (500, 'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental-debug'), (1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.12.0 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

-- 
Samuel
<y> muhahaha...
<y> ya un train qui part de Perrache à 14h57
<y> qui passe à Part-Dieu à 15h10
<y> si je le prends à Perrache, je suis en zone bleue
<y> si je le prends à Part-Dieu, je suis en zone blanche
<y> donc je vais le prendre à Perrache *mais* à Part-Dieu ;-)
 -+- #ens-mim - vive la SNCF -+-
-------------- next part --------------
diff -Nru speech-dispatcher-0.8.6/debian/changelog speech-dispatcher-0.8.6/debian/changelog
--- speech-dispatcher-0.8.6/debian/changelog	2017-03-05 23:13:08.000000000 +0100
+++ speech-dispatcher-0.8.6/debian/changelog	2017-08-08 01:07:02.000000000 +0200
@@ -1,3 +1,9 @@
+speech-dispatcher (0.8.6-4+deb9u1) stretch; urgency=medium
+
+  * patches/spd-conf: Fix spd-conf (Closes: #860898).
+
+ -- Samuel Thibault <sthibault at debian.org>  Tue, 08 Aug 2017 01:07:02 +0200
+
 speech-dispatcher (0.8.6-4) unstable; urgency=medium
 
   * Fix stripped audio output of flite module (Closes: #856895).
diff -Nru speech-dispatcher-0.8.6/debian/patches/series speech-dispatcher-0.8.6/debian/patches/series
--- speech-dispatcher-0.8.6/debian/patches/series	2017-03-05 22:50:12.000000000 +0100
+++ speech-dispatcher-0.8.6/debian/patches/series	2017-08-08 01:07:02.000000000 +0200
@@ -2,3 +2,4 @@
 doc-figures
 change-default-module.patch
 flite-strip-silence
+spd-conf
diff -Nru speech-dispatcher-0.8.6/debian/patches/spd-conf speech-dispatcher-0.8.6/debian/patches/spd-conf
--- speech-dispatcher-0.8.6/debian/patches/spd-conf	1970-01-01 01:00:00.000000000 +0100
+++ speech-dispatcher-0.8.6/debian/patches/spd-conf	2017-08-08 01:06:35.000000000 +0200
@@ -0,0 +1,19 @@
+--- a/src/api/python/speechd_config/config.py.in
++++ b/src/api/python/speechd_config/config.py.in
+@@ -156,6 +156,7 @@ def setup_argparse():
+     parser.add_argument('-D', '--debug', dest='debug',
+             action="store_true", default=False,
+             help=_("Debug a problem and generate a report"))
++    return parser
+ 
+ class Tests:
+     """Tests of functionality of Speech Dispatcher and its dependencies
+@@ -746,7 +747,7 @@ you have to start it manually to continu
+ 
+ def main():
+     options = setup_argparse()
+-    options.parse()
++    options = options.parse_args()
+     test = Tests()
+     configure = Configure(test) # that should possibly be refactored, test should not be passed
+