[Tts-project] Bug#930132: speech-dispatcher-baratinoo: Spelling does not work in Orca

[Samuel Thibault]

Package: speech-dispatcher-baratinoo
Version: 0.9.0-7+hypra1+marks
Severity: important
Tags: patch upstream

When using the baratinoo speech synthesis, none of the character
spelling triggered by Orca works. So for instance, the character
feedback while typing and character feedback while moving along text are
not working, making the synthesis way less useful for daily workflow.

This was fixed upstream by the attached one-liner.

Samuel

-- System Information:
Debian Release: 10.0
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 'testing-debug'), (500, 'stable-debug'), (500, 'proposed-updates-debug'), (500, 'proposed-updates'), (500, 'oldoldstable'), (500, 'buildd-unstable'), (500, 'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental-debug'), (1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.1.0 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages speech-dispatcher-baratinoo depends on:
ii  libc6              2.28-10
ii  libdotconf0        1.3-0.3
ii  libglib2.0-0       2.58.3-1
ii  libltdl7           2.4.6-9
ii  libsndfile1        1.0.28-6
ii  speech-dispatcher  0.9.0-7+hypra1+marks

Versions of packages speech-dispatcher-baratinoo recommends:
ii  voxygen  8.1-1

speech-dispatcher-baratinoo suggests no packages.

-- no debconf information

-- 
Samuel
<g> r: et la marmotte, elle écrit un papier IPDPS
-------------- next part --------------
commit 8018ad3ac98a93a0f64adeca79b0877e9d59e655
Author: Samuel Thibault <samuel.thibault at ens-lyon.org>
Date:   Mon Apr 15 17:41:30 2019 +0200

    baratinoo: do not assume that CHAR commands contain SSML

diff --git a/src/modules/baratinoo.c b/src/modules/baratinoo.c
index 46fdec17..e1fd64b9 100644
--- a/src/modules/baratinoo.c
+++ b/src/modules/baratinoo.c
@@ -472,7 +472,7 @@ int module_speak(gchar *data, size_t bytes, SPDMessageType msgtype)
 	case SPD_MSGTYPE_SPELL: /* FIXME: use \spell one day? */
 	case SPD_MSGTYPE_CHAR:
 		g_string_append(buffer, "\\sayas<{characters}");
-		append_ssml_as_proprietary(engine, buffer, data, bytes);
+		g_string_append_len(buffer, data, bytes);
 		g_string_append(buffer, "\\sayas>{}");
 		break;
 	default: /* FIXME: */