[Tux4kids-tuxtype-dev] Tuxtype 1.7.1 source tar.gz posted

[Lars Vogdt]

Hi David

Updated the tuxtype package in the Build Service and get the following 
compiler warnings:
------------------------------------[snip]
scripting.c: In function 'TestLesson':
scripting.c:148: warning: pointer targets in passing argument 1 of 
'sprintf' differ in signedness
scripting.c:149: warning: pointer targets in passing argument 1 of 
'CheckFile' differ in signedness
scripting.c:159: warning: pointer targets in passing argument 1 of 
'sprintf' differ in signedness
scripting.c:160: warning: pointer targets in passing argument 1 of 
'CheckFile' differ in signedness
scripting.c:183: warning: pointer targets in passing argument 1 of 
'opendir' differ in signedness
scripting.c:198: warning: pointer targets in passing argument 1 of 
'sprintf' differ in signedness
scripting.c:213: warning: implicit declaration of function 'BlackOutline'
scripting.c:213: warning: assignment makes pointer from integer without 
a cast
scripting.c:214: warning: assignment makes pointer from integer without 
a cast
scripting.c:272: warning: implicit declaration of function 'inRect'
scripting.c: In function 'load_script':
scripting.c:539: warning: ignoring return value of 'fscanf', declared 
with attribute warn_unused_result
scripting.c: In function 'run_script':
scripting.c:1262: warning: pointer targets in passing argument 2 of 
'ConvertFromUTF8' differ in signedness
scripting.c: At top level:
------------------------------------[snap]

at least the "assignment makes pointer from integer without a cast" 
warnings should be fixed for 64bit compatibility.

I fixed this warning by including SDL_extras.h:

Index: src/scripting.c
===================================================================
--- src/scripting.c.orig
+++ src/scripting.c
@@ -17,6 +17,7 @@
 
***************************************************************************/

  #include "scripting.h"
+#include "SDL_extras.h"
  #define MAX_LESSONS 100

  /* Local function prototypes: */

...but I haven't tested any of the resulting binary rpms yet.

BTW: What about providing the fonts as extra package or using system fonts?

With kind regards,
Lars