[Tux4kids-tuxtype-dev] [Patch] Fix buzzer when typing <esc>

[Marc Finet]

Hello,

As i was trying tuxtype (1.8.1 from debian wheezy), as i find a nice
alternative to 'learn correct typing' with fun, i encountered small
bugs in lazer:
 - buzzer was played while playing escape
 - music level was not kept after a new music was playing
 - list of 'words' (animals, small words, ...) was a little bit short
on my screen and did not notice on first sight that there was an
arrow at the bottom.

Attached is a patch for the first problem against debian version (that
i quickly tested successfully, and which does not seem to embed
patches).

I have a few other questions:
 - is there a coding style/recommendation ?
 - how should patch be submitted ? attached ? in-line ?
 - regarding the second point it might be linked to .mod handling in
SDL, as problem does not occur in 'playgame.c' aka cascade. Patching
audio.c to Mix_VolumeMusic(Mix_VolumeMusic(-1)); fixed that problem
but i'm not sure it's OK to add it to tuxtype as is rather seems a SDL
problem (debian is currently shipping an old one, i.e. 1.2.8 which
is a few years old... and problem might have been fixed since then as
mod handling part has been reworked)
 - where is the best place to discuss about features/pb encountered ?
this list which seem (according to archive) more spam than
'interesting' mails. I tried to create an account on alioth, but was
unable to login (might be a wrong password, but, alioth did not give
any entry point: webmaster, e-mail address...)
 - about the 'features', i think of the following:
   - change the default behavior of <esc> in pause to return the game
rather than coming back to menu, that is changing the behavior;
   - adding a menu at beginning like 'pause' regarding sound and
music settings;
   - [dev-only] re-write some parts to factorize some parts of code.

Cheers,

Marc.

PS: i did not yet have a look at the third pb, regarding the list
being shorten while screen could propose more options...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tuxtype-no-buzz-on-options-key.diff
Type: text/x-diff
Size: 1146 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/tux4kids-tuxtype-dev/attachments/20111012/c7d01b26/attachment.diff>