patches-applied historical imports (usd import)

[Guido Günther]

On Wed, Jan 11, 2017 at 07:36:05PM +0100, Guido Günther wrote:
> On Mon, Jan 09, 2017 at 02:41:48PM -0800, Nish Aravamudan wrote:
> > On 09.01.2017 [15:36:08 -0700], Sean Whitton wrote:
> > > Hello Nish,
> > > 
> > > On Mon, Jan 09, 2017 at 02:15:53PM -0800, Nish Aravamudan wrote:
> > > > > Have you considered obtaining the patches-applied tree using
> > > > > `dpkg-source -x`?  That applies the patches without using quilt(1), so
> > > > > might workaround this sort of bug (if it didn't, the package would
> > > > > FTBFS).
> > > > 
> > > > Well, I would do that, but afaict, there is no way to tell dpkg-source
> > > > to only apply one patch at a time? This is to go from a
> > > > patches-unapplied state to the fully patches-applied state, commiting
> > > > each patch application into the repository. Perhaps I missed a flag in
> > > > the manpage, though?
> > > 
> > > Good point, I don't think it can be done.
> > > 
> > > It's really quite a serious problem for quilt to be choking on patch
> > > queues.  How many packages did you see with this?  It might be that we
> > > could get it fixed before you finalise your tool.
> > 
> > Agreed, it's a bit perplexing when it happens :)
> > 
> > Honestly, we don't see it with any recent packages, afaict. And I think
> > of the packages I've manually been importing lately, we only ran into
> > the specified issues with util-linux and samba. I am about to start
> > 'automated' test imports based upon the publishing records in Launchpad
> > as a test for a subset of packages my team cares about, that will
> > probably give us better data :)
> 
> Great. I ran a import (gbp import-dsc dscfile && gbp pq import) of
> Debian unstable during dc16 with different gbp versions (ignoring
> history data for the moment). With the most recent gbp at that time
> (0.8.0) it looked like:
> 
> all: 24457
> errors:
>     all: 429
>     import-dsc:
>       errors:
>         all: 219
>         fetch_source: 193     (download failures, can be ignored)
>         pristinetar_delta: 20   
>         permission_denied: 3
>         no_tree_found: 1
>         others: 2
>     pq-import: 
>       errors:
>         all: 210
>         not_apply: 71
>         not_in_index: 81
>         already_in_index: 13
>         corrupt_patch: 29
>         others: 16

We're doing considerably better with gbp 0.8.9 and pristine-tar
1.37:

all: 25715
errors:
    all: 193
    import-dsc: 
      errors:
        all: 21
        fetch_source: 1
        pristinetar_delta: 17
        permission_denied: 1
        submodules: 0
        no_tree_found: 0
        others: 2
      unhandled_excpeptions: 
        all: 0
    pq-import: 
      errors:
        all: 172
        not_apply: 43
        not_in_index: 68
        already_in_index: 15
        corrupt_patch: 27
        others: 19
      unhandled_exceptions: 
        all: 0

I'll look into the git apply that affect gbp pq next.
Cheers,
 -- Guido