[Pkg-javascript-devel] [RFS]node-d3-selection[1.1.5]

[abhijith sheheer]

Thanks. I didn't know about minimum version of pkg-js was needed for
backporting. And didn't know about the privacy issue and img/ directory.

On Tue, 10 Dec 2019, 12:19 am Xavier, <yadd at debian.org> wrote:

> Le 09/12/2019 à 18:25, abhijith sheheer a écrit :
> > node-d3-brush has been updated to 1.1.5 . It passes successfully in
> > clean chroot. Also passes test suite and reverse dependencies (node-d3)
> > as in ``meta/test`` script.
> > Link: https://salsa.debian.org/js-team/node-d3-brush/commits/master
> > Needs reviewing and sponsoring.
> > P.S:  I accidentally pushed to js-tean repo instead of my local project
> :/
> > Thanks in advance.
>
> Hi,
>
> built and pushed. However take a look at my changes:
>  * img/ dir is used by README.md only, then install it using debian/docs
>    and patch README.md to use them instead of github ones (little
>    privacy breach)
>  * don't insert pkg-js-tools auto installed files in debian/install
>  * require a minimal version of pkg-js-tools (> 0.8), else backports
>    will fail
>  * always verify package using "cme check dpkg": it gave
>    - unneeded build dependency versions
>    - bad license name in debian/copyright
>
> Cheers,
> Xavier
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20191210/5c3d92c1/attachment.html>