Bug#958382: node-mqtt: please make the build reproducible

[Chris Lamb]

Source: node-mqtt
Version: 3.0.0-1
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: umask
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort we noticed that node-
mqtt could not be built reproducibly.

This is because it does not fix the permissions of a number of .js
files (ie. it excludes them via "dh_fixperms -X") and thus they are
affected the build system's umask:

│ │ │ │ --rwxr-xr-x   0 root         (0) root         (0)     3076 2019-05-27 08:20:41.000000 ./usr/share/nodejs/mqtt/bin/pub.js
│ │ │ │ --rwxr-xr-x   0 root         (0) root         (0)     2605 2019-05-27 08:20:41.000000 ./usr/share/nodejs/mqtt/bin/sub.js
│ │ │ │ +-rwxrwxr-x   0 root         (0) root         (0)     3076 2019-05-27 08:20:41.000000 ./usr/share/nodejs/mqtt/bin/pub.js
│ │ │ │ +-rwxrwxr-x   0 root         (0) root         (0)     2605 2019-05-27 08:20:41.000000 ./usr/share/nodejs/mqtt/bin/sub.js

I can't quite tell the underlying reason for these excludes as the
files appear to be correctly installed for me (ie. 0644) so a patch
attached that simply drops the dh_fixperms override entirely. If it is
needed for another reason, please ensure that any change or similar is
not affected by the umask. 


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: node-mqtt.diff.txt
URL: <http://alioth-lists.debian.net/pipermail/reproducible-bugs/attachments/20200421/78b89593/attachment.txt>