[Android-tools-devel] Review of icu4j-4.2

[殷啟聰]

Hi Markus,

Thanks for your detailed review! Are we not supposed to discuss this
in Java Team's list?

I was simply making the least changes to this package since this is a clone.

* jh_installjavadoc is indeed useless because it's not producing a
javadoc package.
* I think unzip is unnecessary since it is used to generate upstream
tarball but not for building.
* I didn't spend too much time on debian/copyright and I'll improve it someday.

And I was aware that you have made some changes to it and uploaded it.
But it was rejected...

Cheers,
Kai-Chung Yan


2016-03-27 7:14 GMT+08:00 Markus Koschany <apo at debian.org>:
> Hello Kai-Chung,
>
> here is my review of icu4j-4.2:
>
> * debian/changelog: Just keep the first entry but delete the rest
> because this is a new package. You should mention this by simply writing
>
> Initial release. (Closes: #819192)
>
> * The NEWS file is obsolete. It can be dropped.
>
> * Please remove copyright-old.txt
>
> * debian/rules:
>
>   Why do you execute jh_installjavadoc in your dh_install override?
>
>   It looks like override_dh_auto_clean can be removed too because it
>   does nothing special.
>
> * debian/control:
>
>   unzip can be removed from Build-Depends because the package can be
>   compiled without it. Or is there another reason why we should keep it?
>
>   Do Andreas Tille and Steffen Moeller intend to co-maintain the
>   package?
>
> README.Debian seems to be targeted for packagers and should be renamed
> to README.source.
>
> debian/copyright:
>
> debian/copyright is incomplete and at least the following licenses are
> missing
>
> src/com/ibm/icu/dev/data/unicode/*
>
> src/com/ibm/icu/dev/eclipse/features/com.ibm.icu/build.properties
> src/com/ibm/icu/dev/eclipse/features/com.ibm.icu.base/build.properties
> src/com/ibm/icu/dev/eclipse/features/com.ibm.icu.jse4/build.properties
>
> probably the whole content under src/com/ibm/icu/dev/eclipse/* is
> licensed under EPL-1.0
>
> Copyright Taligent, Inc. 1996, 1997 (which license applies here)
> src/com/ibm/icu/dev/test/format/IntlTestSimpleDateFormatAPI.java
>
> 2005-2008, International Business Machines
> Copyright Taligent, Inc. 1996 - All Rights Reserved
>
> So it looks like this one is covered by the ICU license too, although
> Taligent is mentioned here again. You should clarify and mention all
> these copyright holders in debian/copyright, otherwise the ftp team will
> reject the package.
>
> src/com/ibm/icu/dev/test/format/MessageRegression.java
>
> The sources contain multiple *.dat files and two jars. They are
> apparently only used for testing purposes but you should mention this
> with a comment in debian/copyright to help the ftp team.
>
> Copyright IBM Corporation, 1996-2009. (license?)
> src/com/ibm/icu/math/BigDecimal.java
> src/com/ibm/icu/math/MathContext.java
>
>
> src/com/ibm/richtext/awtui/*
> src/com/ibm/richtext/demo/* ?
> src/com/ibm/richtext/print/MConstTextPrintable.java
>
> and many more...
>
> Copyright IBM Corp. 1998-2004.  All Rights Reserved.
>  *
>  * The program is provided "as is" without any warranty express or
>  * implied, including the warranty of non-infringement and the implied
>  * warranties of merchantibility and fitness for a particular purpose.
>  * IBM will not be liable for any damages suffered by you as a result
>  * of using the Program. In no event will IBM be liable for any
>  * special, indirect or consequential damages or lost profits even if
>  * IBM has been advised of the possibility of their occurrence. IBM
>  * will not be liable for any third party claims against you.
>  */
>
> Regards,
>
> Markus
>
>
>
> _______________________________________________
> Android-tools-devel mailing list
> Android-tools-devel at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/android-tools-devel



-- 
/*
* 殷啟聰 | Kai-Chung Yan
* 一生只向真理與妻子低頭
* Undergraduate student in National Taichung University of Education
* LinkedIn: <https://linkedin.com/in/seamlik>
* Blog: <http://seamlik.logdown.com>
*/