[Android-tools-devel] RFS: android-platform-external-doclava/6.0.1+r55-1 [ITP]

[Hans-Christoph Steiner]

殷啟聰:
> Hi,
> 
> I have prepared a new package "android-platform-external-doclava".
> This package is a fork of Doclava by AOSP, which builds a
> pkg:doclava-aosp.
> 
> Doclava is the necessary tool to build "android.jar".
> 
> The ITP can be found at [1], and the Git repository can be found at [2].
> 
> Cheers,
> Kai-Chung Yan
> 
> [1]: https://bugs.debain.org/833566
> [2]: https://anonscm.debian.org/cgit/android-tools/android-platform-external-doclava.git

Looks good overall.  I don't know much about the java-specific stuff
like the POMs.



You missed a few copyright lines, try running this in the root of the
package source:
find * -type f | xargs grep -i copyright | less



A couple of lintian things to check:

P: android-platform-external-doclava source:
source-contains-prebuilt-javascript-object
res/assets/templates/assets/prettify.js line length is 632 characters (>512)

P: android-platform-external-doclava source:
source-contains-prebuilt-javascript-object
res/assets/templates/assets/jquery-resizable.min.js

If those are used in the final package, then their sources need to be
included.  If they are not used in the binary package, then there should
be a lintian override for the source package about those issues saying
that they are not used in the binary packages.

.hc