[Android-tools-devel] RFS: android-platform-external-doclava/6.0.1+r55-1 [ITP]

[殷啟聰]

Hi Hans,

I have updated d/copyright to mention the GPL and MIT licenses.

Since Doclava is a HTML generator, it surely uses those Javascript
files, therefore we can't simply remove them.

Since the Lintian info are neither "warnings" nor "errors", we don't
really need an override. I typically only override Lintian errors.

Cheers,
Kai-Chung Yan

2016-08-10 19:19 GMT+08:00 Hans-Christoph Steiner <hans at at.or.at>:
>
> 殷啟聰:
>> Hi,
>>
>> I have prepared a new package "android-platform-external-doclava".
>> This package is a fork of Doclava by AOSP, which builds a
>> pkg:doclava-aosp.
>>
>> Doclava is the necessary tool to build "android.jar".
>>
>> The ITP can be found at [1], and the Git repository can be found at [2].
>>
>> Cheers,
>> Kai-Chung Yan
>>
>> [1]: https://bugs.debain.org/833566
>> [2]: https://anonscm.debian.org/cgit/android-tools/android-platform-external-doclava.git
>
> Looks good overall.  I don't know much about the java-specific stuff
> like the POMs.
>
>
>
> You missed a few copyright lines, try running this in the root of the
> package source:
> find * -type f | xargs grep -i copyright | less
>
>
>
> A couple of lintian things to check:
>
> P: android-platform-external-doclava source:
> source-contains-prebuilt-javascript-object
> res/assets/templates/assets/prettify.js line length is 632 characters (>512)
>
> P: android-platform-external-doclava source:
> source-contains-prebuilt-javascript-object
> res/assets/templates/assets/jquery-resizable.min.js
>
> If those are used in the final package, then their sources need to be
> included.  If they are not used in the binary package, then there should
> be a lintian override for the source package about those issues saying
> that they are not used in the binary packages.
>
> .hc
>
> _______________________________________________
> Android-tools-devel mailing list
> Android-tools-devel at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/android-tools-devel



-- 
/*
* 殷啟聰 | Kai-Chung Yan
* 一生只向真理與妻子低頭
* Undergraduate student in National Taichung University of Education
* LinkedIn: <https://linkedin.com/in/seamlik>
* Blog: <http://seamlik.logdown.com>
*/