[Android-tools-devel] Review for android-framework-23

[Markus Koschany]

Hi Chirayu,

I had a closer look at android-framework-23. First of all the package
won't build in a clean chroot environment. (missing or wrong
build-dependencies?)

debian/copyright is not complete:

I suggest to use a * paragraph that covers the predominant license, in
this case Apache-2.0

The external and libcore directories are not covered by any license
paragraph at the moment.

Expat and BSD-3 licenses are also missing:

licensecheck -r . | grep "BSD"


./libcore/NOTICE: MIT/X11 (BSD like)
./libcore/luni/MODULE_LICENSE_BSD_LIKE: *No copyright* UNKNOWN
./libcore/luni/bouncycastle-license.txt: MIT/X11 (BSD like)
./libcore/luni/license.html: *No copyright* MIT/X11 (BSD like)
./frameworks/base/obex/NOTICE: BSD (3 clause)
./frameworks/base/libs/hwui/utils/LinearAllocator.cpp: BSD (2 clause)
./frameworks/base/libs/hwui/utils/LinearAllocator.h: BSD (2 clause)
./frameworks/base/obex/javax/obex/ApplicationParameter.java: BSD (3 clause)
./frameworks/base/obex/javax/obex/Authenticator.java: BSD (3 clause)
./frameworks/base/obex/javax/obex/BaseStream.java: BSD (3 clause)
./frameworks/base/obex/javax/obex/ClientOperation.java: BSD (3 clause)
./frameworks/base/obex/javax/obex/ClientSession.java: BSD (3 clause)
./frameworks/base/obex/javax/obex/HeaderSet.java: BSD (3 clause)
./frameworks/base/obex/javax/obex/ObexHelper.java: BSD (3 clause)
./frameworks/base/obex/javax/obex/ObexSession.java: BSD (3 clause)
./frameworks/base/obex/javax/obex/ObexTransport.java: BSD (3 clause)
./frameworks/base/obex/javax/obex/Operation.java: BSD (3 clause)
./frameworks/base/obex/javax/obex/PasswordAuthentication.java: BSD (3
clause)
./frameworks/base/obex/javax/obex/PrivateInputStream.java: BSD (3 clause)
./frameworks/base/obex/javax/obex/PrivateOutputStream.java: BSD (3 clause)
./frameworks/base/obex/javax/obex/ResponseCodes.java: BSD (3 clause)
./frameworks/base/obex/javax/obex/ServerOperation.java: BSD (3 clause)
./frameworks/base/obex/javax/obex/ServerRequestHandler.java: BSD (3 clause)
./frameworks/base/obex/javax/obex/ServerSession.java: BSD (3 clause)
./frameworks/base/obex/javax/obex/SessionNotifier.java: BSD (3 clause)
./libcore/luni/src/main/native/canonicalize_path.cpp: BSD (2 clause)
./frameworks/base/core/jni/android/graphics/HarfBuzzNGFaceSkia.cpp: BSD
(3 clause)
./frameworks/base/core/jni/android/graphics/HarfBuzzNGFaceSkia.h: BSD (2
clause)
./frameworks/base/telephony/java/com/android/ims/internal/IImsEcbm.aidl:
BSD (3 clause)
./frameworks/base/telephony/java/com/android/ims/internal/IImsEcbmListener.aidl:
BSD (3 clause)
./libcore/xml/src/main/java/org/kxml2/io/KXmlParser.java: MIT/X11 (BSD like)
./libcore/xml/src/main/java/org/kxml2/io/KXmlSerializer.java: MIT/X11
(BSD like)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/android-tools-devel/attachments/20160906/ff785a26/attachment.sig>