[Android-tools-devel] Review for android-framework-23

Chirayu Desai chirayudesai1 at gmail.com
Tue Sep 6 18:51:01 UTC 2016


Hi Markus,


On 09/06/2016 10:58 PM, Markus Koschany wrote:
> Hi Chirayu,
>
> I had a closer look at android-framework-23. First of all the package
> won't build in a clean chroot environment. (missing or wrong
> build-dependencies?)
I'm getting a build error here when trying to build using cowbuilder,
due to a character encoding issue. The source has non-ASCII characters.
>
> debian/copyright is not complete:
Ah yep. I totally forgot to update this, sorry about that.
>
> I suggest to use a * paragraph that covers the predominant license, in
> this case Apache-2.0
>
> The external and libcore directories are not covered by any license
> paragraph at the moment.
I'll put the libcore notices from it's separate repo, and also add the
junit licenses.
>
> Expat and BSD-3 licenses are also missing:
>
> licensecheck -r . | grep "BSD"
>
>
> ./libcore/NOTICE: MIT/X11 (BSD like)
> ./libcore/luni/MODULE_LICENSE_BSD_LIKE: *No copyright* UNKNOWN
> ./libcore/luni/bouncycastle-license.txt: MIT/X11 (BSD like)
> ./libcore/luni/license.html: *No copyright* MIT/X11 (BSD like)
> ./frameworks/base/obex/NOTICE: BSD (3 clause)
> ./frameworks/base/libs/hwui/utils/LinearAllocator.cpp: BSD (2 clause)
> ./frameworks/base/libs/hwui/utils/LinearAllocator.h: BSD (2 clause)
> ./frameworks/base/obex/javax/obex/ApplicationParameter.java: BSD (3 clause)
> ./frameworks/base/obex/javax/obex/Authenticator.java: BSD (3 clause)
> ./frameworks/base/obex/javax/obex/BaseStream.java: BSD (3 clause)
> ./frameworks/base/obex/javax/obex/ClientOperation.java: BSD (3 clause)
> ./frameworks/base/obex/javax/obex/ClientSession.java: BSD (3 clause)
> ./frameworks/base/obex/javax/obex/HeaderSet.java: BSD (3 clause)
> ./frameworks/base/obex/javax/obex/ObexHelper.java: BSD (3 clause)
> ./frameworks/base/obex/javax/obex/ObexSession.java: BSD (3 clause)
> ./frameworks/base/obex/javax/obex/ObexTransport.java: BSD (3 clause)
> ./frameworks/base/obex/javax/obex/Operation.java: BSD (3 clause)
> ./frameworks/base/obex/javax/obex/PasswordAuthentication.java: BSD (3
> clause)
> ./frameworks/base/obex/javax/obex/PrivateInputStream.java: BSD (3 clause)
> ./frameworks/base/obex/javax/obex/PrivateOutputStream.java: BSD (3 clause)
> ./frameworks/base/obex/javax/obex/ResponseCodes.java: BSD (3 clause)
> ./frameworks/base/obex/javax/obex/ServerOperation.java: BSD (3 clause)
> ./frameworks/base/obex/javax/obex/ServerRequestHandler.java: BSD (3 clause)
> ./frameworks/base/obex/javax/obex/ServerSession.java: BSD (3 clause)
> ./frameworks/base/obex/javax/obex/SessionNotifier.java: BSD (3 clause)
> ./libcore/luni/src/main/native/canonicalize_path.cpp: BSD (2 clause)
> ./frameworks/base/core/jni/android/graphics/HarfBuzzNGFaceSkia.cpp: BSD
> (3 clause)
> ./frameworks/base/core/jni/android/graphics/HarfBuzzNGFaceSkia.h: BSD (2
> clause)
> ./frameworks/base/telephony/java/com/android/ims/internal/IImsEcbm.aidl:
> BSD (3 clause)
> ./frameworks/base/telephony/java/com/android/ims/internal/IImsEcbmListener.aidl:
> BSD (3 clause)
> ./libcore/xml/src/main/java/org/kxml2/io/KXmlParser.java: MIT/X11 (BSD like)
> ./libcore/xml/src/main/java/org/kxml2/io/KXmlSerializer.java: MIT/X11
> (BSD like)
Note to self: Some of these would need to be added to
src:android-platform-frameworks-base too.
>
>
>
> _______________________________________________
> Android-tools-devel mailing list
> Android-tools-devel at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/android-tools-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/android-tools-devel/attachments/20160907/484fb94b/attachment.html>


More information about the Android-tools-devel mailing list