[Android-tools-devel] Review for android-framework-23

[殷啟聰]

Hi Markus,

Thanks for the review. I did the removal of execution permission in
d/rules but looks like I missed some of the files. I now fixed it. I
also improved the package description, and renamed the package
`android-platform-23` to `android-sdk-platform-23` in order to be
consistent with other android-sdk meta packages.

According to the manpage, dh_fixperms seems to only process the files
in certain locations like `/usr/share/doc`. But it may makes sense to
also remove the execution permissions from files in `/usr/share`, but
there may be exceptions that I never thought of.

Cheers,
Kai-Chung Yan

2016-10-11 21:43 GMT+08:00 Markus Koschany <apo at debian.org>:
> On 11.10.2016 11:12, 殷啟聰 wrote:
>> Hi Markus,
>>
>> I now fixed the build failure and add more license entries to
>> d/copyright. However I never noticed any encoding errors either with
>> debuild or pbuilder. Perhaps Chirayu's modification fixed it?
>>
>> Markus, could you review it again? Thank you!
>
> Thanks for the update. The package builds fine now.
>
>
> Did you see these warnings?
>
> android-platform-23: executable-not-elf-or-script
>
> I think removing the executable bit in debian/rules would be the best
> way. I don't know why dh_fixperms is unable to fix that.
>
> Rest looks good to me although the package description is a bit sparse.
>
> Cheers,
>
> Markus
>
>
> _______________________________________________
> Android-tools-devel mailing list
> Android-tools-devel at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/android-tools-devel



-- 
/*
* 殷啟聰 | Kai-Chung Yan
* 一生只向真理與妻子低頭
* Undergraduate student in National Taichung University of Education
* LinkedIn: <https://linkedin.com/in/seamlik>
* Blog: <http://seamlik.logdown.com>
*/