[Android-tools-devel] Bug#853310: android-platform-system-core: ftbfs with GCC-7

[Raphael Hertzog]

Hello,

On Tue, 11 Sep 2018, 殷啟聰 | Kai-Chung Yan wrote:
> Sorry for being dormant on the matter. We had been in the process of
> updating the whole SDK suite to Oreo but it is blocked by an upload of
> this package. The latest update produces several new packages so I don't
> have the permission to upload it, and the DDs in the team were too busy
> as well.

Who are the DD in the team? Are there other contributors currently
following the process to become a DD?

> It would be wonderful if you could sponsor the upload. We have prepared
> everything on Salsa, all you need to do is to change "UNRELEASED" to
> "experimental" in the changelog. The RFS [1] has more details.

It would have helped if you had given me the URL of the repository.
Anyway, I'm willing to sponsor the update (even though I don't know much
about Android Tools) but I have a few comments:

1/ your RFS mentions the need to do a "stage1" upload but you actually
manually dropped the package and the build dependencies that were tagged
stage1, why did you do that?

2/ I don't understand why you replace "android-tools-mkbootimg" with
"mkbootimg". The latter package has a very generic name while the former
was rather explicit. It looks like a step backwards. Yes, now it matches
the name of the executable inside the package, but I'm not sure it
justifies introducing a new package and dealing with a transitional
package. What was your rationale? And you should have documented your
rationale in the commit messages and in the changelog entry.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 523 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/android-tools-devel/attachments/20180911/e3ac6bc4/attachment-0001.sig>