[Android-tools-devel] Bug#853310: android-platform-system-core: ftbfs with GCC-7

[殷啟聰 | Kai-Chung Yan]

> Who are the DD in the team? Are there other contributors currently
> following the process to become a DD?

Mostly Hans (eighthave) is the DD involved a lot, and Markus (apo) occasionally helps. I am currently going through the process of becoming a DD but it is going very slowly.

> It would have helped if you had given me the URL of the repository.
> Anyway, I'm willing to sponsor the update (even though I don't know much
> about Android Tools) but I have a few comments:

Thank you for the sponsor, it will help us a lot!

The repository is at <https://salsa.debian.org/android-tools-team/android-platform-system-core>. Sorry about that, I thought it was too trivial.

> 1/ your RFS mentions the need to do a "stage1" upload but you actually
> manually dropped the package and the build dependencies that were tagged
> stage1, why did you do that?

"stage1" is everything but "fastboot". "fastboot" depends on some libraries in "android-platform-system-extras" which also depend on libraries in this source package, making a circular dependency. We are going to upload the full version after "android-platform-system-extras" gets uploaded.

"buildd" does not support staged uploads, so we have to manually remove "fastboot", hence the "~stage1" part of the version.

> 2/ I don't understand why you replace "android-tools-mkbootimg" with
> "mkbootimg". The latter package has a very generic name while the former
> was rather explicit. It looks like a step backwards. Yes, now it matches
> the name of the executable inside the package, but I'm not sure it
> justifies introducing a new package and dealing with a transitional
> package. What was your rationale? And you should have documented your
> rationale in the commit messages and in the changelog entry.

We have renamed "adb" and "fastboot" as well, and we are doing the same for "mkbootimg" this time. For the moment, the names of these programs have been well-known and exclusive in the society, so I don't think the "android-tools-" prefix is necessary. For a name, they seem not that generic to me as I've seen something more so (e.g. "docker" and "node", which did caused name conflicts in Debian).

Another reason has been mentioned by you: They match the executables.

There are other executables built by this package with names more generic, like "img2simg" and "append2simg". We put them together in a single package (as you can see in the changelog") because they belong to the same subproject "libsparse". Unfortunately "mkbootimg" lives on its own so I just make it its own package.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/android-tools-devel/attachments/20180913/72eb962f/attachment.sig>