[Android-tools-devel] Bug#935308: buster-pu: package android-sdk-meta/25.0.0+11

[Adam D. Barratt]

Control: tags -1 + moreinfo

On Wed, 2019-08-21 at 15:44 +0200, Hans-Christoph Steiner wrote:
> I have been working on polishing this package for buster since March,
> but I didn't make the freeze cutoff.  This mostly adds new device IDs
> to
> the udev rules so that those devices will be recognized.  It also
> fixes
> debian/copyright and some minor usability bugs:

Again I have to ask why the changes took so long in that case,
particularly if they're mostly syncs from upstream.

> 924175: broken symlink: /usr/lib/android-sdk/tools/bin/screenshot2
> 923935: broken symlinks: proguardgui, proguardgui.jar
> 
> I uploaded this package to sid so that it runs the autopkgtest suite.

Well, and SRM policy requires the changes to be in unstable first in
any case.

> Here's the changelog since the current version in buster:
> 
>  android-sdk-meta (25.0.0+11) unstable; urgency=medium

The changes we're interested in, and what should be attached in your
request, are the changes between the current package in stable and the
package that you are proposing to upload to stable, as built and tested
on stable ready for upload.

As it is, you've uploaded a package using a version number that is
confusing when combined with your changelog (as we would have pointed
out if you had waited before uploading):

+android-sdk-meta (25.0.0+11~deb10u1) buster; urgency=medium

Such a version should include the changelog for the +11 upload to
unstable, and then have a short "rebuild for buster" or similar stanza
for ~deb10u1, in the same fashion as one would for backports. The style
that you've used is generally used for +10+deb10u1 versioning.
 .
>    [ Jeff Muizelaar ]
>    * Add some more Amazon devices
>  .
>    [ Hans-Christoph Steiner ]
>    * fix DEB_REVISION parsing to work with more than one digit
> 

I assume that's this change:

-DEB_REVISION = $(shell echo $(DEB_VERSION) | sed 's,.*\+\([0-9][0-9]*\).*,\1,')
+DEB_REVISION = $(shell echo $(DEB_VERSION) | sed 's,.*+\([0-9][0-9]*\).*,\1,')

However, I'm confused as to how this corresponds to the description. It
removes a match for a literal "+" symbol, but does nothing related to
the number of digits involved so far as I can tell.

>    * remove broken screenshot2 symlink (Closes: #924175)
>    * Suggests: proguard-gui for symlinks (Closes: #923935)
>    * document udev rule for providing device access to the console
> user
>    * update udev rules to latest upstream version (Closes: #931215)
>    * sync new devices in 51-android.rules from upstream
>    * Standards-Version 4.3.0 no changes
>    * sync whitespace in 51-android.rules with upstream
>    * sync comments in 51-android.rules with upstream
>    * sync manufacturer order in 51-android.rules from upstream

Those last three changes sound like they could have made the diff a
fair bit smaller with no functional difference.

 debian/android-sdk.metainfo.xml                  |  109 ++++++

+debian/android-sdk.metainfo.xml  usr/share/metainfo

Is that related to one of the items mentioned in the changelog?

On Mon, 2019-08-26 at 12:18 +0200, Hans-Christoph Steiner wrote:
> I forgot this important detail: LineageOS would recommend this as the
> official install method for these udev rules if this update was
> included in buster:

I'm afraid that's not really important in terms of whether the changes
are suitable for a stable update.

Regards,

Adam