[Android-tools-devel] Bug#935308: buster-pu: package android-sdk-meta/25.0.0+11

Tue Aug 27 08:30:03 BST 2019

Adam D. Barratt:
> Control: tags -1 + moreinfo
> 
> On Wed, 2019-08-21 at 15:44 +0200, Hans-Christoph Steiner wrote:
>> I have been working on polishing this package for buster since March,
>> but I didn't make the freeze cutoff.  This mostly adds new device IDs
>> to
>> the udev rules so that those devices will be recognized.  It also
>> fixes
>> debian/copyright and some minor usability bugs:
> 
> Again I have to ask why the changes took so long in that case,
> particularly if they're mostly syncs from upstream.

This is my first try to start a process to include new device IDs in
Debian/stable so that these devices work with Debian/stable without
extra tricks.  There are always new Android devices, which will have new
device IDs.  I think that if Debian is going to provide

It is true, some other changes could have already been included, like
the metadata file.  I didn't see that AppStream lintian warning/error
until I did the work to sync with upstream, which was after the buster
freeze.  Since I knew I was going to go through the proposed updates
process anyway, I lumped all the changes together to reduce the load on
the release team.

>> 924175: broken symlink: /usr/lib/android-sdk/tools/bin/screenshot2
>> 923935: broken symlinks: proguardgui, proguardgui.jar
>>
>> I uploaded this package to sid so that it runs the autopkgtest suite.
> 
> Well, and SRM policy requires the changes to be in unstable first in
> any case.
> 
>> Here's the changelog since the current version in buster:
>>
>>  android-sdk-meta (25.0.0+11) unstable; urgency=medium
> 
> The changes we're interested in, and what should be attached in your
> request, are the changes between the current package in stable and the
> package that you are proposing to upload to stable, as built and tested
> on stable ready for upload.
> 
> As it is, you've uploaded a package using a version number that is
> confusing when combined with your changelog (as we would have pointed
> out if you had waited before uploading):
> 
> +android-sdk-meta (25.0.0+11~deb10u1) buster; urgency=medium
> 
> Such a version should include the changelog for the +11 upload to
> unstable, and then have a short "rebuild for buster" or similar stanza
> for ~deb10u1, in the same fashion as one would for backports. The style
> that you've used is generally used for +10+deb10u1 versioning.

Thanks for this explanation!  I was looking all over for this.  It was
not in the manual.  So I looked through other packages tagged with
release.debian.org, and copied what I saw there.  From what I read,
+deb10u1 is for security updates that are not also in testing/sid, and
~deb10u1 is for things also in testing/sid.

So right now, the changelog entry for 25.0.0+11 in testing and
25.0.0+11~deb10u1 in proposed-updated are the exact same, except for the
date and ~deb10u1.  I figured that 25.0.0+11 would never be in buster.
Should I make ~deb10u2 to do the changes you describe?

Seems like the FAQ on this page could be a good place for this to be
explained:
https://wiki.debian.org/StableProposedUpdates

I can edit this discussion into a FAQ there, if you agree.

>>    [ Jeff Muizelaar ]
>>    * Add some more Amazon devices
>>  .
>>    [ Hans-Christoph Steiner ]
>>    * fix DEB_REVISION parsing to work with more than one digit
>>
> 
> I assume that's this change:
> 
> -DEB_REVISION = $(shell echo $(DEB_VERSION) | sed 's,.*\+\([0-9][0-9]*\).*,\1,')
> +DEB_REVISION = $(shell echo $(DEB_VERSION) | sed 's,.*+\([0-9][0-9]*\).*,\1,')
>
> However, I'm confused as to how this corresponds to the description. It
> removes a match for a literal "+" symbol, but does nothing related to
> the number of digits involved so far as I can tell.

sed != PCRE.   By default, sed does not treat + as a special character.
 'sed -E' makes it PCRE.   This was fixed by testing.  The original
regex was only ever returning a single digit, this returns one or more.
 I've been writing regexs for over 20 years, and this one took me a
while to see...

>>    * remove broken screenshot2 symlink (Closes: #924175)
>>    * Suggests: proguard-gui for symlinks (Closes: #923935)
>>    * document udev rule for providing device access to the console
>> user
>>    * update udev rules to latest upstream version (Closes: #931215)
>>    * sync new devices in 51-android.rules from upstream
>>    * Standards-Version 4.3.0 no changes
>>    * sync whitespace in 51-android.rules with upstream
>>    * sync comments in 51-android.rules with upstream
>>    * sync manufacturer order in 51-android.rules from upstream
> 
> Those last three changes sound like they could have made the diff a
> fair bit smaller with no functional difference.
> 
>  debian/android-sdk.metainfo.xml                  |  109 ++++++
> 
> +debian/android-sdk.metainfo.xml  usr/share/metainfo
> 
> Is that related to one of the items mentioned in the changelog?

* document udev rule for providing device access to the console user

> On Mon, 2019-08-26 at 12:18 +0200, Hans-Christoph Steiner wrote:
>> I forgot this important detail: LineageOS would recommend this as the
>> official install method for these udev rules if this update was
>> included in buster:
> 
> I'm afraid that's not really important in terms of whether the changes
> are suitable for a stable update.

I mentioned it to give an example of the kinds of things that will be
possible if the list of device IDs can be updated via proposed updates.
 Also, FYI, this package is what Google officially recommends to Android
developers for installing the device IDs:
https://developer.android.com/studio/run/device

.hc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/android-tools-devel/attachments/20190827/97a967ac/attachment-0001.sig>