[Android-tools-devel] Review of android-platform-external-libunwind

[殷啟聰]

Hi Hans,

Thanks for the review! Actually I copied debian/copyright from the original
libunwind package ;)

The debian/detect-arch.mk queries DEB_HOST_ARCH_CPU variable which I think
returns one of the values in the "Debian name" column
of /usr/share/dpkg/cputable file, and I think this is the same variable for
the "Architecture" field in debian/control. Once I was putting armel and
armhf to the "Architecture" field and Lintian said that they are not valid
CPU types, then I headed to #debian-qa for the issue, someone told me that
the value of "Architecture" field can be found in /usr/share/dpkg/cputable
file. So I think "arm" covers both armel and armhf. I put "armeb" as well
because it exists in that file.

I myself is confident that Android SDK is runnable on ARM and MIPS
machines. From the AndroidConfig.h and some Android.mk elsewhere we can
know that all programs and libraries can be built for the host version on
x86, ARM and MIPS platforms, although Google only releases x86 SDK.

For the hardening warnings, I think some deep bugs cause that because I
applied the dpkg flags to the compiler and I can see the build commands are
already set the proper flags. When I was packaging libnative-platform-java
I was facing the same issue.

Cheers,
Kai-Chung Yan

Hans-Christoph Steiner <hans at at.or.at> 於 2015年8月19日週三 上午1:23寫道：

>
> Hey seamlik,
>
> Looks good, nice work on debian/copyright, lots of stuff there.
>
> It looks like you removed 'armhf' support and added 'armeb' support, if I
> am
> following debian/detect-arch.mk correctly.  'armeb' is dead.  'armhf' and
> 'armel' are active, as far as I know:
>
> https://wiki.debian.org/ArmHardFloatPort
> https://buildd.debian.org/
>
> Also, there are some lintian warnings that should be dealt with:
>
> * postrm-has-useless-call-to-ldconfig - I did a lintian override to hide
> this
> warning on other packages like in android-platform-system-core.  I included
> the same one since it is the same issue.
>
> * hardening-no-fortify-functions - Other android-lib* packages have gotten
> this working, so it would be good to have them on this package too.
>
> Since Google only supports amd64 and i386 for the Android SDK, I went
> ahead an
> uploaded this package without the changes to the ARM names.  If you get
> around
> to fixing the issues here, then we can upload a new package version.
>
> .hc
>
> 殷啟聰:
> > Hi,
> >
> > I believe android-platform-external-libunwind is ready for review now.
> This
> > package is an AOSP fork of libunwind with modifications specific for
> > Android, so we need it packaged separated from the origianl libunwind. It
> > installs the libraries to /usr/lib/android so they won't affect the
> system.
> >
> > Currently the only r-depends is libbacktrace of android-platform-system.
> >
> > android-platform-external-libunwind:
> >
> http://anonscm.debian.org/cgit/android-tools/android-platform-external-libunwind.git
> >
> > android-platform-system:
> > http://anonscm.debian.org/cgit/android-tools/android-platform-system.git
> >
> > Thank you!
> >
> > Cheers,
> > Kai-Chung Yan
> >
>
-- 

殷啟聰 | Kai-Chung Yan
一生只向真理與妻子低頭
Full-time student of National Taichung University of Education
LinkedIn: <https://linkedin.com/in/seamlik>
Blog: <http://seamlik.logdown.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/android-tools-devel/attachments/20150819/f4c73fed/attachment.html>