[Aptitude-devel] 002-qt-stubs-review round 2 part 1

[Piotr Galiszewski]

2010/7/20 Daniel Burrows <dburrows at debian.org>:
>  I've merged the parent of this commit, so only the tabs_manager is
> outstanding on this branch.  It's not perfect, but it'll do as a starting
> point for future work.  I also wrote a quick patch to fix up a bunch of
> comments and some indentation, to avoid round-tripping just for that.
>

Thanks a lot! Please inform me about this issues, so I could add them
to my todo list

>  There is one thing I'm a bit worried about: the tabs_widget
> destructor.  In general, running nontrivial code from C++ destructors is
> a sketchy idea.  If this is a normal Qt idiom, I guess I can live with
> it, but I'd prefer to avoid it if possible.
>

I wasn't Qt idiom ;) . It is fixed in new version of tabs_manager patch

>  Daniel
>
> _______________________________________________
> Aptitude-devel mailing list
> Aptitude-devel at lists.alioth.debian.org
> http://lists.alioth.debian.org/mailman/listinfo/aptitude-devel
>
-- 
Regards
Piotr Galiszewski