[Babel-users] [PATCHv4] Allow to independently monitor and dump events for neighbour, interface, route, xroute

Antonin Décimo antonin.decimo at gmail.com
Fri Oct 4 16:13:44 BST 2019


Hello again,

> - SHOW_* macros should directly point to their bit, like the IF_*
>   macros in interface.h
>   -#define SHOW_NEIGHBOUR 1
>   -#define SHOW_INTERFACE 2
>   +#define SHOW_NEIGHBOUR (1 << 0)
>   +#define SHOW_INTERFACE (1 << 1)

Of course this has absolutely no impact on the code, I just feel that
it is more consistent with what was done with the interface configuration.

> - In the case:
>   +    case CONFIG_ACTION_MONITOR:
>   +    case CONFIG_ACTION_UNMONITOR:
>   +    case CONFIG_ACTION_DUMP:
>   +        return 0xff;

After some discussion with Juliusz, he convinced me that return 0xff
is sufficiently clear.  Please forget about my comments.

Thanks!

-- Antonin



More information about the Babel-users mailing list