[Debian-astro-maintainers] Bug#895368: pymoc: don't try to run python upstream testsuite on archs without healpy

[Steve Langasek]

Package: pymoc
Version: 0.5.0-2
Severity: minor
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu bionic ubuntu-patch

Dear maintainers,

Whereas Debian currently only regularly runs autopkgtests for amd64, in
Ubuntu, we run the autopkgtests across all architectures.  The pymoc
autopkgtests fail on several architectures, because they depend on
python{,3}-healpy, which has a hard-coded architecture list of [amd64 arm64
ppc64el].  However, pymoc itself only Suggests: python{,3}-healpy, implying
the package is still usable and should still be made available on these
other architectures, but the tests are wrong for these architectures.

I have uploaded the attached patch to Ubuntu, to architecture-restrict the
running of the upstream test suite as an autopkgtest; this allows us to
still run the 'pymoctool' autopkgtest and gather successful test results on
these architectures, rather than having to entirely ignore these test
results.

Please consider including this change in Debian as well.

Thanks,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
diff -Nru pymoc-0.5.0/debian/tests/control pymoc-0.5.0/debian/tests/control
--- pymoc-0.5.0/debian/tests/control	2018-02-22 00:42:32.000000000 -0800
+++ pymoc-0.5.0/debian/tests/control	2018-04-09 23:32:42.000000000 -0700
@@ -1,9 +1,9 @@
 Tests: upstream-python3-pymoc
-Depends: python3-pymoc, python3-healpy
+Depends: python3-pymoc, python3-healpy [amd64 arm64 ppc64el]
 Restrictions: allow-stderr
 
 Tests: upstream-python-pymoc
-Depends: python-pymoc, python-healpy
+Depends: python-pymoc, python-healpy [amd64 arm64 ppc64el]
 Restrictions: allow-stderr
 
 Tests: pymoctool
diff -Nru pymoc-0.5.0/debian/tests/upstream-python3-pymoc pymoc-0.5.0/debian/tests/upstream-python3-pymoc
--- pymoc-0.5.0/debian/tests/upstream-python3-pymoc	2018-02-21 06:57:29.000000000 -0800
+++ pymoc-0.5.0/debian/tests/upstream-python3-pymoc	2018-04-10 09:44:09.000000000 -0700
@@ -1,5 +1,13 @@
 #!/bin/sh
 # per example given in README.rst
 echo "exec upstream unittests under Python 3"
+case $(dpkg --print-architecture) in
+    amd64|arm64|ppc64el)
+        ;;
+    *)
+        echo "SKIPPED: healpy not available on this architecture"
+        exit 0
+        ;;
+esac
 exec python3 -m unittest
 
diff -Nru pymoc-0.5.0/debian/tests/upstream-python-pymoc pymoc-0.5.0/debian/tests/upstream-python-pymoc
--- pymoc-0.5.0/debian/tests/upstream-python-pymoc	2018-02-21 06:57:29.000000000 -0800
+++ pymoc-0.5.0/debian/tests/upstream-python-pymoc	2018-04-10 09:44:22.000000000 -0700
@@ -1,4 +1,12 @@
 #!/bin/sh
 # per example given in README.rst
 echo "exec upstream unittests under Python 2"
+case $(dpkg --print-architecture) in
+    amd64|arm64|ppc64el)
+        ;;
+    *)
+        echo "SKIPPED: healpy not available on this architecture"
+        exit 0
+        ;;
+esac
 exec python2 -m unittest discover