[Debian-astro-maintainers] Bug#1098084: wcstools: ftbfs with GCC-15

[Matthias Klose]

Package: src:wcstools
Version: 3.9.7-1.1
Severity: important
Tags: sid forky
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-15

[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/wcstools_3.9.7-1.1_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
imsetwcs.c:1130:1: warning: old-style function definition [-Wold-style-definition]
 1130 | setnxydec (ndec)
      | ^~~~~~~~~
imsetwcs.c: In function ‘setmatch’:
imsetwcs.c:1139:1: warning: old-style function definition [-Wold-style-definition]
 1139 | setmatch (cat)
      | ^~~~~~~~
imsetwcs.c: In function ‘setreflim’:
imsetwcs.c:1144:1: warning: old-style function definition [-Wold-style-definition]
 1144 | setreflim (lim1, lim2)
      | ^~~~~~~~~
imsetwcs.c: In function ‘setfitwcs’:
imsetwcs.c:1151:1: warning: old-style function definition [-Wold-style-definition]
 1151 | setfitwcs (wfit)
      | ^~~~~~~~~
imsetwcs.c: In function ‘setfitplate’:
imsetwcs.c:1156:1: warning: old-style function definition [-Wold-style-definition]
 1156 | setfitplate (nc)
      | ^~~~~~~~~~~
imsetwcs.c: In function ‘setminstars’:
imsetwcs.c:1161:1: warning: old-style function definition [-Wold-style-definition]
 1161 | setminstars (minstars)
      | ^~~~~~~~~~~
imsetwcs.c:1164:3: error: too many arguments to function ‘setminbin’; expected 0, have 1
 1164 |   setminbin (minstars);
      |   ^~~~~~~~~  ~~~~~~~~
imsetwcs.c:52:13: note: declared here
   52 | extern void setminbin();
      |             ^~~~~~~~~
imsetwcs.c: In function ‘setfrac’:
imsetwcs.c:1172:1: warning: old-style function definition [-Wold-style-definition]
 1172 | setfrac (frac0)
      | ^~~~~~~
imsetwcs.c: In function ‘setimfrac’:
imsetwcs.c:1180:1: warning: old-style function definition [-Wold-style-definition]
 1180 | setimfrac (frac0)
      | ^~~~~~~~~
imsetwcs.c: In function ‘setmaxcat’:
imsetwcs.c:1187:1: warning: old-style function definition [-Wold-style-definition]
 1187 | setmaxcat (ncat)
      | ^~~~~~~~~
imsetwcs.c: In function ‘setiterate’:
imsetwcs.c:1194:1: warning: old-style function definition [-Wold-style-definition]
 1194 | setiterate (iter)
      | ^~~~~~~~~~
imsetwcs.c: In function ‘setnfiterate’:
imsetwcs.c:1200:1: warning: old-style function definition [-Wold-style-definition]
 1200 | setnfiterate (iter)
      | ^~~~~~~~~~~~
imsetwcs.c: In function ‘setiteratet’:
imsetwcs.c:1206:1: warning: old-style function definition [-Wold-style-definition]
 1206 | setiteratet (iter)
      | ^~~~~~~~~~~
imsetwcs.c: In function ‘setrecenter’:
imsetwcs.c:1212:1: warning: old-style function definition [-Wold-style-definition]
 1212 | setrecenter (recenter)
      | ^~~~~~~~~~~
imsetwcs.c: In function ‘setsortmag’:
imsetwcs.c:1218:1: warning: old-style function definition [-Wold-style-definition]
 1218 | setsortmag (imag)
      | ^~~~~~~~~~
make[3]: *** [<builtin>: imsetwcs.o] Error 1
make[3]: Leaving directory '/build/reproducible-path/wcstools-3.9.7/libwcs'
make[2]: *** [Makefile:201: libwcs/libwcstools.so] Error 2
make[2]: Leaving directory '/build/reproducible-path/wcstools-3.9.7'
dh_auto_build: error: make -j1 "INSTALL=install --strip-program=true" returned exit code 2
make[1]: *** [debian/rules:13: override_dh_auto_build-arch] Error 25
make[1]: Leaving directory '/build/reproducible-path/wcstools-3.9.7'
make: *** [debian/rules:9: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2