[Debian-astro-maintainers] Bug#1098115: x11iraf: ftbfs with GCC-15

[Matthias Klose]

Package: src:x11iraf
Version: 2.2~rc1+dfsg-5
Severity: important
Tags: sid forky
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-15

[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/x11iraf_2.2~rc1+dfsg-5_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
      |                                 %s
widget.c:2120:34: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘caddr_t’ {aka ‘char *’} [-Wformat=]
 2120 |             sprintf (result, "0x%x", value);
      |                                 ~^   ~~~~~
      |                                  |   |
      |                                  |   caddr_t {aka char *}
      |                                  unsigned int
      |                                 %s
widget.c: In function ‘widgetAddEventHandler’:
widget.c:4391:31: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
 4391 |         new_cb->client_data = (XtPointer) event_mask;
      |                               ^
widget.c: In function ‘widgetRemoveEventHandler’:
widget.c:4434:42: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
 4434 |             XtRemoveEventHandler (wp->w, (int) cb->client_data, nonmaskable,
      |                                          ^
widget.c: In function ‘widgetEvent’:
widget.c:4502:32: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 3 has type ‘Time’ {aka ‘long unsigned int’} [-Wformat=]
 4502 |                 sprintf (op, "%u %d %d %d %d ",
      |                               ~^
      |                                |
      |                                unsigned int
      |                               %lu
 4503 |                     ev->time, ev->x, ev->y, ev->x_root, ev->y_root);
      |                     ~~~~~~~~    
      |                       |
      |                       Time {aka long unsigned int}
widget.c:4533:32: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 3 has type ‘Time’ {aka ‘long unsigned int’} [-Wformat=]
 4533 |                 sprintf (op, "%u %d %d %d %d ",
      |                               ~^
      |                                |
      |                                unsigned int
      |                               %lu
 4534 |                     ev->time, ev->x, ev->y, ev->x_root, ev->y_root);
      |                     ~~~~~~~~    
      |                       |
      |                       Time {aka long unsigned int}
widget.c:4557:29: warning: ‘XKeycodeToKeysym’ is deprecated [-Wdeprecated-declarations]
 4557 |                             keysym = XKeycodeToKeysym (obm->display,
      |                             ^~~~~~
In file included from /usr/include/X11/Intrinsic.h:53,
                 from ObmP.h:16,
                 from widget.c:5:
/usr/include/X11/Xlib.h:1683:15: note: declared here
 1683 | extern KeySym XKeycodeToKeysym(
      |               ^~~~~~~~~~~~~~~~
widget.c:4575:32: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 3 has type ‘Time’ {aka ‘long unsigned int’} [-Wformat=]
 4575 |                 sprintf (op, "%u %d %d %d %d ",
      |                               ~^
      |                                |
      |                                unsigned int
      |                               %lu
 4576 |                     ev->time, ev->x, ev->y, ev->x_root, ev->y_root);
      |                     ~~~~~~~~    
      |                       |
      |                       Time {aka long unsigned int}
widget.c: In function ‘widgetGetFontName’:
widget.c:4742:43: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘long unsigned int’ [-Wformat=]
 4742 |                         sprintf(name, "%s%d", name, val);
      |                                          ~^         ~~~
      |                                           |         |
      |                                           int       long unsigned int
      |                                          %ld
make[2]: *** [<builtin>: gterm.o] Error 1
make[2]: Leaving directory '/build/reproducible-path/x11iraf-2.2~rc1+dfsg/obm'
make[1]: *** [Makefile:11: obm/libobm.a] Error 2
make[1]: Leaving directory '/build/reproducible-path/x11iraf-2.2~rc1+dfsg'
dh_auto_build: error: make -j8 "INSTALL=install --strip-program=true" returned exit code 2
make: *** [debian/rules:8: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2