[Debian-ha-maintainers] Bug#664645: ldirectord: suspicious init script

[Simon Horman]

On Mon, Mar 19, 2012 at 03:23:24PM +0100, Ferenc Wagner wrote:
> Package: ldirectord
> Version: 1:3.9.2-5
> Severity: normal
> 
> Hi,
> 
> The /etc/init.d/ldirectord init script contains the lines:
> 
>         exec "$DAEMON" "$CONFIG_FILE" $1
>         RC=$?
>         [...]
> 
> Since the exec shell builtin does not return if $DAEMON is executable,
> the error checking and logging after it makes me suspicious: is that
> exec really intentional?  For me it looks like it should be removed.

Hi,

I believe that the intention of the code is that the error handling
is performed if and only if exec fails, e.g. because "$DAEMON" is
not executable.

The upstream version of the init script has the exec without the RC
handling, which seems to indicate that the exec is intentional.