[Debian-ha-maintainers] Bug#664645: ldirectord: suspicious init script

[Ferenc Wagner]

Simon Horman <horms at verge.net.au> writes:

> On Mon, Mar 19, 2012 at 03:23:24PM +0100, Ferenc Wagner wrote:
> 
>> The /etc/init.d/ldirectord init script contains the lines:
>> 
>>         exec "$DAEMON" "$CONFIG_FILE" $1
>>         RC=$?
>>         [...]
>> 
>> Since the exec shell builtin does not return if $DAEMON is executable,
>> the error checking and logging after it makes me suspicious: is that
>> exec really intentional?  For me it looks like it should be removed.
>
> I believe that the intention of the code is that the error handling
> is performed if and only if exec fails, e.g. because "$DAEMON" is
> not executable.
>
> The upstream version of the init script has the exec without the RC
> handling, which seems to indicate that the exec is intentional.

Hi Simon,

Then in my opinion the upstream exec is indeed intentional, but it
should be removed in the Debian version, because it breaks the output of
the log_daemon_msg/log_end_msg pair (by skipping the latter; this is a
rather ugly can of worms, though, see the last comment of
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=208010 for example).
-- 
Regards,
Feri.